Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 1152273004: Add support for transforms to container (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
eseidel
CC:
gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add support for transforms to container These transforms are currently very basic but they seem to mostly work. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b9b6d821a10719a6ae39a8dfc5b1feb9653080a2

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -4 lines) Patch
M sky/examples/fn2/container.dart View 2 chunks +0 lines, -2 lines 0 comments Download
A sky/examples/raw/transform.dart View 1 chunk +27 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/fn2.dart View 5 chunks +22 lines, -1 line 0 comments Download
M sky/sdk/lib/framework/rendering/box.dart View 2 chunks +71 lines, -1 line 1 comment Download
M sky/sdk/pubspec.yaml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
abarth-chromium
5 years, 6 months ago (2015-06-03 17:12:16 UTC) #1
eseidel
lgtm https://codereview.chromium.org/1152273004/diff/1/sky/sdk/lib/framework/rendering/box.dart File sky/sdk/lib/framework/rendering/box.dart (right): https://codereview.chromium.org/1152273004/diff/1/sky/sdk/lib/framework/rendering/box.dart#newcode324 sky/sdk/lib/framework/rendering/box.dart:324: void translate(x, [double y=0.0, double z=0.0]) { Does ...
5 years, 6 months ago (2015-06-03 17:16:18 UTC) #2
abarth-chromium
Committed patchset #1 (id:1) manually as b9b6d821a10719a6ae39a8dfc5b1feb9653080a2 (presubmit successful).
5 years, 6 months ago (2015-06-03 17:20:38 UTC) #3
Matt Perry
I was planning on exposing some of the SkMatrix operations in the painting API. Would ...
5 years, 6 months ago (2015-06-03 17:32:30 UTC) #4
abarth-chromium
5 years, 6 months ago (2015-06-03 19:35:56 UTC) #5
Message was sent while issue was closed.
On 2015/06/03 at 17:32:30, mpcomplete wrote:
> I was planning on exposing some of the SkMatrix operations in the painting
API. Would that let you drop the dependency on vector_math.dart?

Unfortunately, I don't that will work everywhere.  There are two competing sets
of requirements:

1) Fast matrix manipulations inside the VM for things like hit testing and
physics engines.
2) Fast drawing operations using matrices.

Using Matrix4 everywhere optimizes for (1).  Using an SkMatrix interface
everywhere optimizes for (2).  Because both are important, we'll need some sort
of hybrid approach where some code uses Matrix4 for in-VM manipulation and some
code uses an SkMatrix interface for painting.  My guess is that RenderTransform
is where the two matrix types will come in contact because the clients of
RenderTransform want to talk in Matrix4, RenderTransform needs to do some
operations with Matrix4, but RenderTransform also needs to talk to Canvas using
SkMatrix.

Powered by Google App Engine
This is Rietveld 408576698