Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1152243003: Fix luci-go isolate support on OSX. (Closed)

Created:
5 years, 7 months ago by M-A Ruel
Modified:
5 years, 7 months ago
CC:
chromium-reviews, tandri_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix luci-go isolate support on OSX. The --extra-variable FOO BAR format is not supported by the Go implementation. Switch to --extra-variable FOO=BAR. Using the second form is only a problem when the value has spaces and only on Windows and this case is OSX only. TBR=vadimsh@chromium.org BUG= Committed: https://crrev.com/ed6da5c8c4695faeb54aa354f48616cfd8207f71 Cr-Commit-Position: refs/heads/master@{#331218}

Patch Set 1 #

Patch Set 2 : Fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M build/isolate.gypi View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
M-A Ruel
5 years, 7 months ago (2015-05-22 23:57:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152243003/1
5 years, 7 months ago (2015-05-22 23:57:50 UTC) #4
tandrii(chromium)
lgtm
5 years, 7 months ago (2015-05-23 00:00:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152243003/20001
5 years, 7 months ago (2015-05-23 00:03:14 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 7 months ago (2015-05-23 00:03:17 UTC) #10
Vadim Sh.
lgtm, I hope python is fine with that
5 years, 7 months ago (2015-05-23 00:04:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152243003/20001
5 years, 7 months ago (2015-05-23 00:05:29 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/65666)
5 years, 7 months ago (2015-05-23 00:13:20 UTC) #15
M-A Ruel
On 2015/05/23 00:13:20, I haz the power - commit-bot wrote: > Try jobs failed on ...
5 years, 7 months ago (2015-05-23 00:22:23 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152243003/20001
5 years, 7 months ago (2015-05-23 00:23:14 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-23 01:38:08 UTC) #19
commit-bot: I haz the power
5 years, 7 months ago (2015-05-23 01:38:49 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ed6da5c8c4695faeb54aa354f48616cfd8207f71
Cr-Commit-Position: refs/heads/master@{#331218}

Powered by Google App Engine
This is Rietveld 408576698