|
Revert of Revert of [Reland] Setup LayoutMenuList to not modify layout tree outside style recalc. (patchset #1 id:1 of https://codereview.chromium.org/1150303003/) Reason for revert: The revert didn't resolve the problem.
> Revert of [Reland] Setup LayoutMenuList to not modify layout tree outside style recalc. (patchset #1 id:1 of https://codereview.chromium.org/1150303003/)
>
> Reason for revert:
> Broke the following tests on Mac:
> AutomationApiTest.Mixins
> BrowserTest.CancelBeforeUnloadResetsURL
> NaClBrowserTestPnacl.PnaclExceptionHandlingDisabled
> PasswordManagerBrowserTest.NoPromptForFailedLoginFromSubFrameWithMultiFramesInPage
>
> Original issue's description:
> > [Reland] Setup LayoutMenuList to not modify layout tree outside style recalc.
> >
> > This CL updates the LayoutMenuList code to not modify the layout
> > tree ourside of style recalc. The way this is done is, instead of creating
> > and destroying LayoutText or LayoutBR elements it just uses
> > LayoutText elements and sets the blank string into them when
> > it would have used LayoutBR previously.
> >
> > This CL was originally landed in r195671 but was reverted in r195695 due to
> > breaking Android accessiblity tests during the blink roll. The two broken tests
> > were:
> > * DumpAccessibilityTreeTest.AccessibilityOptgroup
> > * DumpAccessibilityTreeTest.AccessibilitySelect
> >
> > Those tests have been marked as skip, needs rebaseline in
> > https://crrev.com/20d41b01d06a8420829a9406eaee773e11239c78
> > so this should be safe to reland.
> >
> > BUG= 370462
TBR=dsinclair@chromium.org
BUG= 370462
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195854
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+206 lines, -174 lines) |
Patch |
 |
A + |
LayoutTests/platform/android/virtual/slimmingpaint/fast/forms/select-baseline-expected.txt
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
A + |
LayoutTests/platform/android/virtual/slimmingpaint/fast/forms/selectlist-minsize-expected.txt
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
A + |
LayoutTests/platform/android/virtual/slimmingpaint/fast/replaced/three-selects-break-expected.txt
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/linux/fast/forms/HTMLOptionElement_label06-expected.txt
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/linux/fast/forms/HTMLOptionElement_label07-expected.txt
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/linux/fast/forms/form-element-geometry-expected.txt
|
View
|
|
3 chunks |
+6 lines, -3 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/linux/fast/forms/menulist-separator-painting-expected.txt
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/linux/fast/forms/select-baseline-expected.txt
|
View
|
|
2 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/linux/fast/forms/select-empty-option-height-expected.txt
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/linux/fast/forms/selectlist-minsize-expected.txt
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/linux/fast/replaced/three-selects-break-expected.txt
|
View
|
|
1 chunk |
+6 lines, -3 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/linux/virtual/slimmingpaint/fast/forms/HTMLOptionElement_label06-expected.txt
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/linux/virtual/slimmingpaint/fast/forms/HTMLOptionElement_label07-expected.txt
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/linux/virtual/slimmingpaint/fast/forms/form-element-geometry-expected.txt
|
View
|
|
3 chunks |
+6 lines, -3 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/linux/virtual/slimmingpaint/fast/forms/menulist-separator-painting-expected.txt
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/linux/virtual/slimmingpaint/fast/forms/select-baseline-expected.txt
|
View
|
|
2 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/linux/virtual/slimmingpaint/fast/forms/select-empty-option-height-expected.txt
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/linux/virtual/slimmingpaint/fast/forms/selectlist-minsize-expected.txt
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/linux/virtual/slimmingpaint/fast/replaced/three-selects-break-expected.txt
|
View
|
|
1 chunk |
+6 lines, -3 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label06-expected.txt
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label07-expected.txt
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/mac/fast/forms/form-element-geometry-expected.txt
|
View
|
|
3 chunks |
+6 lines, -3 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/mac/fast/forms/menulist-separator-painting-expected.txt
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/mac/fast/forms/select-baseline-expected.txt
|
View
|
|
2 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/mac/fast/forms/select-empty-option-height-expected.txt
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/mac/fast/forms/selectlist-minsize-expected.txt
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/mac/fast/replaced/three-selects-break-expected.txt
|
View
|
|
1 chunk |
+6 lines, -3 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/mac/virtual/slimmingpaint/fast/forms/HTMLOptionElement_label06-expected.txt
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/mac/virtual/slimmingpaint/fast/forms/HTMLOptionElement_label07-expected.txt
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/mac/virtual/slimmingpaint/fast/forms/form-element-geometry-expected.txt
|
View
|
|
3 chunks |
+6 lines, -3 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/mac/virtual/slimmingpaint/fast/forms/menulist-separator-painting-expected.txt
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/mac/virtual/slimmingpaint/fast/forms/select-baseline-expected.txt
|
View
|
|
2 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/mac/virtual/slimmingpaint/fast/forms/select-empty-option-height-expected.txt
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/mac/virtual/slimmingpaint/fast/forms/selectlist-minsize-expected.txt
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/mac/virtual/slimmingpaint/fast/replaced/three-selects-break-expected.txt
|
View
|
|
1 chunk |
+6 lines, -3 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/win-xp/fast/forms/HTMLOptionElement_label06-expected.txt
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/win-xp/fast/forms/HTMLOptionElement_label07-expected.txt
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/win-xp/fast/forms/form-element-geometry-expected.txt
|
View
|
|
3 chunks |
+6 lines, -3 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/win-xp/fast/forms/select-baseline-expected.txt
|
View
|
|
2 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
 |
D |
LayoutTests/platform/win-xp/virtual/slimmingpaint/fast/forms/menulist-separator-painting-expected.txt
|
View
|
|
1 chunk |
+0 lines, -12 lines |
0 comments
|
Download
|
 |
D |
LayoutTests/platform/win-xp/virtual/slimmingpaint/fast/forms/select-empty-option-height-expected.txt
|
View
|
|
1 chunk |
+0 lines, -11 lines |
0 comments
|
Download
|
 |
D |
LayoutTests/platform/win-xp/virtual/slimmingpaint/fast/forms/selectlist-minsize-expected.txt
|
View
|
|
1 chunk |
+0 lines, -10 lines |
0 comments
|
Download
|
 |
D |
LayoutTests/platform/win-xp/virtual/slimmingpaint/fast/replaced/three-selects-break-expected.txt
|
View
|
|
1 chunk |
+0 lines, -18 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/win/fast/forms/HTMLOptionElement_label06-expected.txt
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/win/fast/forms/HTMLOptionElement_label07-expected.txt
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/win/fast/forms/form-element-geometry-expected.txt
|
View
|
|
3 chunks |
+6 lines, -3 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/win/fast/forms/menulist-separator-painting-expected.txt
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/win/fast/forms/select-baseline-expected.txt
|
View
|
|
2 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/win/fast/forms/select-empty-option-height-expected.txt
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/win/fast/forms/selectlist-minsize-expected.txt
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/win/fast/replaced/three-selects-break-expected.txt
|
View
|
|
1 chunk |
+6 lines, -3 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/win/virtual/slimmingpaint/fast/forms/HTMLOptionElement_label06-expected.txt
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/win/virtual/slimmingpaint/fast/forms/HTMLOptionElement_label07-expected.txt
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/win/virtual/slimmingpaint/fast/forms/form-element-geometry-expected.txt
|
View
|
|
3 chunks |
+6 lines, -3 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/win/virtual/slimmingpaint/fast/forms/menulist-separator-painting-expected.txt
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/win/virtual/slimmingpaint/fast/forms/select-baseline-expected.txt
|
View
|
|
2 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/win/virtual/slimmingpaint/fast/forms/select-empty-option-height-expected.txt
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/win/virtual/slimmingpaint/fast/forms/selectlist-minsize-expected.txt
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/win/virtual/slimmingpaint/fast/replaced/three-selects-break-expected.txt
|
View
|
|
1 chunk |
+6 lines, -3 lines |
0 comments
|
Download
|
 |
M |
Source/core/layout/LayoutMenuList.h
|
View
|
|
2 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
 |
M |
Source/core/layout/LayoutMenuList.cpp
|
View
|
|
8 chunks |
+35 lines, -39 lines |
0 comments
|
Download
|
Total messages: 3 (1 generated)
|