Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1152213003: Flesh out Rect/Point/Size classes in dart:sky (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
Matt Perry, Hixie
CC:
Hixie, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -8 lines) Patch
M sky/engine/core/core.gni View 1 chunk +2 lines, -1 line 0 comments Download
M sky/engine/core/painting/Point.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/painting/Rect.dart View 1 chunk +32 lines, -1 line 4 comments Download
A + sky/engine/core/painting/Size.dart View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
abarth-chromium
5 years, 6 months ago (2015-05-28 16:33:42 UTC) #1
abarth-chromium
5 years, 6 months ago (2015-05-28 16:33:59 UTC) #2
Matt Perry
lgtm with fix below https://codereview.chromium.org/1152213003/diff/1/sky/engine/core/painting/Rect.dart File sky/engine/core/painting/Rect.dart (right): https://codereview.chromium.org/1152213003/diff/1/sky/engine/core/painting/Rect.dart#newcode35 sky/engine/core/painting/Rect.dart:35: Size get size => new ...
5 years, 6 months ago (2015-05-28 16:41:21 UTC) #3
abarth-chromium
Committed patchset #1 (id:1) manually as 24c178ce9beb6142bfc12d1c048e259106d1ff1f (presubmit successful).
5 years, 6 months ago (2015-05-28 16:42:21 UTC) #4
Hixie
5 years, 6 months ago (2015-05-28 17:20:11 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/1152213003/diff/1/sky/engine/core/painting/Re...
File sky/engine/core/painting/Rect.dart (right):

https://codereview.chromium.org/1152213003/diff/1/sky/engine/core/painting/Re...
sky/engine/core/painting/Rect.dart:8: Float32List _value;
Move these to below the constructors?

https://codereview.chromium.org/1152213003/diff/1/sky/engine/core/painting/Re...
sky/engine/core/painting/Rect.dart:16: Rect.fromPointAndSize(Point point, Size
size) {
why isn't this a constructor?

https://codereview.chromium.org/1152213003/diff/1/sky/engine/core/painting/Re...
sky/engine/core/painting/Rect.dart:24: Rect.fromLTRB(double left, double top,
double right, double bottom) {
ditto

Powered by Google App Engine
This is Rietveld 408576698