Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Unified Diff: build/secondary/third_party/android_tools/BUILD.gn

Issue 1152203003: Add script to validate installed Android SDK packages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make the minimum version requirement more explicit Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/install-android-sdks.sh ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/secondary/third_party/android_tools/BUILD.gn
diff --git a/build/secondary/third_party/android_tools/BUILD.gn b/build/secondary/third_party/android_tools/BUILD.gn
index dc934cb93e40b50637fdfd939f6726d272f02e3e..6f8336ba85d31c8573df670b23223d6a32b21d91 100644
--- a/build/secondary/third_party/android_tools/BUILD.gn
+++ b/build/secondary/third_party/android_tools/BUILD.gn
@@ -89,6 +89,25 @@ android_java_prebuilt("google_play_services_default_java") {
deps = [
":android_support_v13_java",
":google_play_services_default_resources",
+ ":check_sdk_extras_version",
]
jar_path = "$android_sdk_root/extras/google/google_play_services/libproject/google-play-services_lib/libs/google-play-services.jar"
}
+action("check_sdk_extras_version") {
+ script = "//build/check_sdk_extras_version.py"
+ args = [
+ "--package-id",
+ "extra-google-google_play_services",
+ "--package-location",
+ rebase_path("$android_sdk_root/extras/google/google_play_services"),
+ "--stamp",
+ rebase_path("$target_gen_dir/checked_sdk_extras_version.stamp"),
+ ]
+ inputs = [
+ "//build/android_sdk_extras.json",
+ "$android_sdk_root/extras/google/google_play_services/libproject/google-play-services_lib/libs/google-play-services.jar",
aberent 2015/06/18 15:36:03 Strictly, I think, this should depend upon the who
dgn 2015/06/18 17:20:17 Good point, thanks. That being said, I'm having t
+ ]
+ outputs = [
+ "$target_gen_dir/checked_sdk_extras_version.stamp",
+ ]
+}
« no previous file with comments | « build/install-android-sdks.sh ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698