lib/src/packages_impl.dart - Issue 1152173005: Add more tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/packages_impl.dart

Issue 1152173005: Add more tests (Closed) Base URL: https://github.com/dart-lang/package_config.git@master

Patch Set: Test discovery functionality Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/packages_impl.dart

diff --git a/lib/src/packages_impl.dart b/lib/src/packages_impl.dart

index 612dc347d39e96ddae4ecacc5901fe67ddb6c6df..956376275da8416d7be98e90b27305fb16c76ab3 100644

--- a/lib/src/packages_impl.dart

+++ b/lib/src/packages_impl.dart

@@ -70,7 +70,7 @@ class FilePackagesDirectoryPackages extends _PackagesBase {

FilePackagesDirectoryPackages(this._packageDir);

Uri _getBase(String packageName) =>

- new Uri.directory(path.join(packageName,''));

+ new Uri.directory(path.join(_packageDir.path, packageName, ''));

Lasse Reichstein Nielsen 2015/05/26 07:14:59 Tests found bug! Yey!

Iterable<String> _listPackageNames() {

return _packageDir.listSync()

« no previous file with comments | « no previous file | test/discovery_test.dart » ('j') | test/discovery_test.dart » ('J')