Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1152173002: X87: [es6] Spread in array literals (Closed)

Created:
5 years, 7 months ago by chunyang.dai
Modified:
5 years, 7 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [es6] Spread in array literals port 9502e91adbed48a546463aa848656d07619d14e6 (r28534) original commit message: This allows you to put iterables into your array literals and the will get spread into the array. let x = [0, ...range(1, 3)]; // [0, 1, 2] This is done by treating the array literal up to the first spread element as usual, including using a boiler plate array, and then appending the remaining expressions and rest expressions. BUG= Committed: https://crrev.com/83321b09ed5764be4d44a6ca7647d184b495732b Cr-Commit-Position: refs/heads/master@{#28606}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -6 lines) Patch
M src/x87/full-codegen-x87.cc View 3 chunks +34 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 7 months ago (2015-05-22 07:23:46 UTC) #2
Weiliang
lgtm
5 years, 7 months ago (2015-05-25 12:51:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152173002/1
5 years, 7 months ago (2015-05-25 12:51:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-25 13:15:26 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-25 13:15:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83321b09ed5764be4d44a6ca7647d184b495732b
Cr-Commit-Position: refs/heads/master@{#28606}

Powered by Google App Engine
This is Rietveld 408576698