Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 1152163008: Drop support for buildtools/linux32 in the GN wrapper. (Closed)

Created:
5 years, 6 months ago by Dirk Pranke
Modified:
5 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, Roland McGrath
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Drop support for buildtools/linux32 in the GN wrapper. Since we no longer have a 32-bit Linux GN binary, we shouldn't try to point to one in the gn.py wrapper; this was hiding a bug on one of the NaCl bots. R=brettw@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295520

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M gclient_utils.py View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Dirk Pranke
5 years, 6 months ago (2015-06-03 21:08:48 UTC) #1
brettw
lgtm
5 years, 6 months ago (2015-06-03 22:06:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152163008/1
5 years, 6 months ago (2015-06-03 22:09:40 UTC) #4
commit-bot: I haz the power
Presubmit check for 1152163008-1 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 6 months ago (2015-06-03 22:13:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152163008/1
5 years, 6 months ago (2015-06-03 22:24:13 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 22:27:11 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295520

Powered by Google App Engine
This is Rietveld 408576698