Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1152163007: Fix scaffold to work for the toolbar. (Closed)

Created:
5 years, 6 months ago by Hixie
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix scaffold to work for the toolbar. Also, make the scaffold code more generic (with slots in a map, instead of dedicated members for each slot). This may eventually benefit from being split into a general "multislot" superclass and a scaffold-specific subclass, but for now it'll do. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0d459fcef027f2457f086ebd97728b300e5b6d6c

Patch Set 1 #

Total comments: 1

Patch Set 2 : make the code less efficient but remove some duplicate code #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -120 lines) Patch
M sky/examples/stocks2/lib/stock_app.dart View 1 2 1 chunk +3 lines, -10 lines 0 comments Download
M sky/sdk/lib/framework/components2/scaffold.dart View 1 2 5 chunks +69 lines, -109 lines 0 comments Download
M sky/sdk/lib/framework/components2/tool_bar.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Hixie
Note that this depends on some changes I have to Point and Rect that are ...
5 years, 6 months ago (2015-06-03 20:35:46 UTC) #1
abarth-chromium
LGTM https://codereview.chromium.org/1152163007/diff/1/sky/sdk/lib/framework/components2/scaffold.dart File sky/sdk/lib/framework/components2/scaffold.dart (right): https://codereview.chromium.org/1152163007/diff/1/sky/sdk/lib/framework/components2/scaffold.dart#newcode179 sky/sdk/lib/framework/components2/scaffold.dart:179: syncChild(floatingActionButton, old is Scaffold ? old.floatingActionButton : null, ...
5 years, 6 months ago (2015-06-03 20:42:04 UTC) #3
Hixie
On 2015/06/03 at 20:42:04, abarth wrote: > LGTM > > https://codereview.chromium.org/1152163007/diff/1/sky/sdk/lib/framework/components2/scaffold.dart > File sky/sdk/lib/framework/components2/scaffold.dart (right): ...
5 years, 6 months ago (2015-06-03 20:50:49 UTC) #4
Hixie
5 years, 6 months ago (2015-06-03 21:50:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
0d459fcef027f2457f086ebd97728b300e5b6d6c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698