src/heap/objects-visiting.cc - Issue 1152153004: Treat weak references in context weakly in write barrier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/objects-visiting.cc

Issue 1152153004: Treat weak references in context weakly in write barrier. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap/objects-visiting.cc

diff --git a/src/heap/objects-visiting.cc b/src/heap/objects-visiting.cc

index de2cfddb28438137df3641c14c85e48818a9bfef..4adf2a5c85f1d66e65acedee31c804fb4462af3d 100644

--- a/src/heap/objects-visiting.cc

+++ b/src/heap/objects-visiting.cc

@@ -287,7 +287,7 @@ struct WeakListVisitor<Code> {

template <>

struct WeakListVisitor<Context> {

static void SetWeakNext(Context* context, Object* next) {

- context->set(Context::NEXT_CONTEXT_LINK, next, UPDATE_WRITE_BARRIER);

+ context->set(Context::NEXT_CONTEXT_LINK, next, UPDATE_WEAK_WRITE_BARRIER);

}

static Object* WeakNext(Context* context) {

« src/contexts.cc ('K') | « src/contexts.cc ('k') | src/objects.h » ('j') | no next file with comments »