Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1152153004: Treat weak references in context weakly in write barrier. (Closed)

Created:
5 years, 7 months ago by Hannes Payer (out of office)
Modified:
5 years, 7 months ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Treat weak references in context weakly in write barrier. BUG= Committed: https://crrev.com/42fc4310783772d7d503e8ab7dde3a7cb3351e00 Cr-Commit-Position: refs/heads/master@{#28658}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -17 lines) Patch
M src/bootstrapper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/contexts.cc View 5 chunks +7 lines, -6 lines 2 comments Download
M src/heap/objects-visiting.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 1 chunk +9 lines, -2 lines 0 comments Download
M src/objects-inl.h View 1 chunk +9 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Hannes Payer (out of office)
5 years, 7 months ago (2015-05-27 13:32:35 UTC) #2
ulan
lgtm https://codereview.chromium.org/1152153004/diff/20001/src/contexts.cc File src/contexts.cc (right): https://codereview.chromium.org/1152153004/diff/20001/src/contexts.cc#newcode397 src/contexts.cc:397: function->set_next_function_link(get(OPTIMIZED_FUNCTIONS_LIST)); set_next_function_link should be weak too. Is this ...
5 years, 7 months ago (2015-05-27 13:35:51 UTC) #3
Hannes Payer (out of office)
https://codereview.chromium.org/1152153004/diff/20001/src/contexts.cc File src/contexts.cc (right): https://codereview.chromium.org/1152153004/diff/20001/src/contexts.cc#newcode397 src/contexts.cc:397: function->set_next_function_link(get(OPTIMIZED_FUNCTIONS_LIST)); On 2015/05/27 13:35:51, ulan wrote: > set_next_function_link should ...
5 years, 7 months ago (2015-05-27 13:49:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152153004/20001
5 years, 7 months ago (2015-05-27 13:49:19 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-27 14:13:09 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 14:13:16 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/42fc4310783772d7d503e8ab7dde3a7cb3351e00
Cr-Commit-Position: refs/heads/master@{#28658}

Powered by Google App Engine
This is Rietveld 408576698