Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1152153003: [WIP] cc: Plumb frame timing info without using a commit. (Closed)

Created:
5 years, 7 months ago by vmpstr
Modified:
5 years, 6 months ago
Reviewers:
Mike B, enne (OOO)
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, Ian Vollick, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WIP] cc: Plumb frame timing info without using a commit. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -17 lines) Patch
M cc/debug/frame_timing_tracker.h View 3 chunks +11 lines, -2 lines 2 comments Download
M cc/debug/frame_timing_tracker.cc View 5 chunks +24 lines, -3 lines 0 comments Download
M cc/debug/frame_timing_tracker_unittest.cc View 10 chunks +57 lines, -9 lines 0 comments Download
M cc/test/fake_layer_tree_host_client.h View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/test/fake_layer_tree_host_impl_client.h View 2 chunks +5 lines, -0 lines 0 comments Download
M cc/test/layer_tree_test.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host.h View 2 chunks +5 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_client.h View 2 chunks +4 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 2 chunks +9 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 2 chunks +8 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_no_message_loop.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M cc/trees/thread_proxy.h View 2 chunks +8 lines, -0 lines 0 comments Download
M cc/trees/thread_proxy.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 2 chunks +6 lines, -2 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +6 lines, -0 lines 1 comment Download
M ui/compositor/compositor.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
vmpstr
enne@, this is the type of posting I was thinking of doing that avoids using ...
5 years, 7 months ago (2015-05-26 17:21:15 UTC) #2
MikeB
https://codereview.chromium.org/1152153003/diff/1/cc/debug/frame_timing_tracker.h File cc/debug/frame_timing_tracker.h (right): https://codereview.chromium.org/1152153003/diff/1/cc/debug/frame_timing_tracker.h#newcode36 cc/debug/frame_timing_tracker.h:36: base::hash_map<int, std::vector<CompositeTimingEvent>>; This should be int64_t. https://codereview.chromium.org/1152153003/diff/1/cc/debug/frame_timing_tracker.h#newcode50 cc/debug/frame_timing_tracker.h:50: base::hash_map<int, ...
5 years, 7 months ago (2015-05-27 21:07:39 UTC) #3
MikeB
5 years, 6 months ago (2015-06-01 19:29:55 UTC) #4 
Looks good to me, with the two notes I outlined.

https://codereview.chromium.org/1152153003/diff/1/content/renderer/gpu/render...
File content/renderer/gpu/render_widget_compositor.cc (right):

https://codereview.chromium.org/1152153003/diff/1/content/renderer/gpu/render...
content/renderer/gpu/render_widget_compositor.cc:965: // TODO(vmpstr): Record
the events.
Recording the events should be (or similar to) 

https://codereview.chromium.org/1137823002/diff/60001/content/renderer/gpu/re...

Powered by Google App Engine
This is Rietveld 408576698