src/full-codegen.cc - Issue 1152093003: [strong] create strong array literals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen.cc

Issue 1152093003: [strong] create strong array literals (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: cl feedback Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen.cc

diff --git a/src/full-codegen.cc b/src/full-codegen.cc

index a25669777144553769883aa0d97b6c4b96d261c4..a8adfb8f3681521b2bbb067f56cae81098a6d3f6 100644

--- a/src/full-codegen.cc

+++ b/src/full-codegen.cc

@@ -412,7 +412,8 @@ bool FullCodeGenerator::MustCreateObjectLiteralWithRuntime(

bool FullCodeGenerator::MustCreateArrayLiteralWithRuntime(

ArrayLiteral* expr) const {

- return expr->depth() > 1 ||

+ // TODO(rossberg): Teach strong mode to FastCloneShallowArrayStub.

+ return expr->depth() > 1 || expr->is_strong() ||

expr->values()->length() > JSObject::kInitialMaxFastElementArray;

}

« no previous file with comments | « src/factory.cc ('k') | src/globals.h » ('j') | no next file with comments »