src/compiler/js-typed-lowering.cc - Issue 1152093003: [strong] create strong array literals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/js-typed-lowering.cc

Issue 1152093003: [strong] create strong array literals (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: ports for x87, ppc Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/js-typed-lowering.cc

diff --git a/src/compiler/js-typed-lowering.cc b/src/compiler/js-typed-lowering.cc

index 8715fba4cde7fb5c9e8ab9d562a04c38154e2940..d4fe91bbfc2b9a36c8d5b61c17c9aa15bd2db1c2 100644

--- a/src/compiler/js-typed-lowering.cc

+++ b/src/compiler/js-typed-lowering.cc

@@ -958,7 +958,9 @@ Reduction JSTypedLowering::ReduceJSCreateLiteralArray(Node* node) {

// Use the FastCloneShallowArrayStub only for shallow boilerplates up to the

// initial length limit for arrays with "fast" elements kind.

+ // TODO(rossberg): Teach strong mode to FastCloneShallowArrayStub.

if ((flags & ArrayLiteral::kShallowElements) != 0 &&

+ (flags & ArrayLiteral::kIsStrong) == 0 &&

length < JSObject::kInitialMaxFastElementArray) {

Isolate* isolate = jsgraph()->isolate();

Callable callable = CodeFactory::FastCloneShallowArray(isolate);