Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1152063003: Remove unnecessary TypeFeedbackIds, saves memory and simplifies TurboFan. (Closed)

Created:
5 years, 7 months ago by mvstanton
Modified:
5 years, 7 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove unnecessary TypeFeedbackIds, saves memory and simplifies TurboFan. Consequence of going whole-hog for vector-based Load/KeyedLoad ICs. BUG= Committed: https://crrev.com/c5b7b9f72f302d7a207769bf523e8a3476f0f322 Cr-Commit-Position: refs/heads/master@{#28596}

Patch Set 1 #

Patch Set 2 : rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -44 lines) Patch
M src/ast.h View 5 chunks +3 lines, -12 lines 0 comments Download
M src/compiler/ast-graph-builder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 11 chunks +26 lines, -30 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
mvstanton
Hi Ben, Could you have a look? thx for it, --Michael
5 years, 7 months ago (2015-05-22 11:45:40 UTC) #2
titzer
LGTM, nice!
5 years, 7 months ago (2015-05-22 11:47:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152063003/1
5 years, 7 months ago (2015-05-22 11:48:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_compile_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/4122)
5 years, 7 months ago (2015-05-22 12:26:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152063003/20001
5 years, 7 months ago (2015-05-22 14:07:52 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-22 14:32:39 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 14:32:57 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c5b7b9f72f302d7a207769bf523e8a3476f0f322
Cr-Commit-Position: refs/heads/master@{#28596}

Powered by Google App Engine
This is Rietveld 408576698