Issue 1152023005: Make "official build" not the default, if is_official_build is not set in gn args.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1152023005: Make "official build" not the default, if is_official_build is not set in gn args. (Closed)

Created:
5 years, 6 months ago by viettrungluu

Modified:
5 years, 6 months ago

Reviewers:
etiennej, qsr

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Make "official build" not the default, if is_official_build is not set in gn args. (Presumably you'd notice it not being set for an Android build, but it's not even used for the Linux build, and the current default only leads to sadness.) R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/e5f3ba53d9245888aa0a7f6c883b1bf1badde7b3

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	mojo/tools/mopy/gn.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

viettrungluu

5 years, 6 months ago (2015-06-02 22:57:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e5f3ba53d9245888aa0a7f6c883b1bf1badde7b3 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages