Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1152023005: Make "official build" not the default, if is_official_build is not set in gn args. (Closed)

Created:
5 years, 6 months ago by viettrungluu
Modified:
5 years, 6 months ago
Reviewers:
etiennej, qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make "official build" not the default, if is_official_build is not set in gn args. (Presumably you'd notice it not being set for an Android build, but it's not even used for the Linux build, and the current default only leads to sadness.) R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/e5f3ba53d9245888aa0a7f6c883b1bf1badde7b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mojo/tools/mopy/gn.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
5 years, 6 months ago (2015-06-02 18:27:40 UTC) #1
qsr
lgtm
5 years, 6 months ago (2015-06-02 21:41:24 UTC) #3
viettrungluu
5 years, 6 months ago (2015-06-02 22:57:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e5f3ba53d9245888aa0a7f6c883b1bf1badde7b3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698