Issue 1152013003: Fix crash in roll_dep.py when key == None

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1152013003: Fix crash in roll_dep.py when key == None (Closed)

Created:
5 years, 6 months ago by Sam Clegg

Modified:
5 years, 6 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Target Ref:
refs/heads/master

Project:
tools

Visibility:
Public.

Fix crash in roll_dep.py when key == None Also, unify error handling to use exceptions. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295465

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -20 lines)			Patch
	M	roll_dep.py	View	1	6 chunks	+27 lines, -20 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152013003/20001

5 years, 6 months ago (2015-05-29 22:00:54 UTC) #5

commit-bot: I haz the power

5 years, 6 months ago (2015-05-29 22:09:41 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295465