Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 1151973009: Share duplicate inline stylesheets in quirks mode. (Closed)

Created:
4 years, 11 months ago by esprehn
Modified:
4 years, 11 months ago
Reviewers:
Timothy Loh, adamk, ojan
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Share duplicate inline stylesheets in quirks mode. The reason for the quirks check was because the cache was originally static and global and quirks and standards change how we process sheets so we made the cache only standards mode. Later we had to make the cache be per document to support media queries which meant this quirks mode special case isn't needed anymore. The original change with the static cache is: https://codereview.chromium.org/28553005 R=ojan@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196460

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -18 lines) Patch
M Source/core/dom/StyleEngine.cpp View 1 chunk +13 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
esprehn
4 years, 11 months ago (2015-06-04 03:27:45 UTC) #2
Timothy Loh
On 2015/06/04 03:27:45, esprehn wrote: lgtm
4 years, 11 months ago (2015-06-04 04:16:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151973009/1
4 years, 11 months ago (2015-06-04 04:32:37 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2015-06-04 05:46:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196460

Powered by Google App Engine
This is Rietveld 408576698