content/test/web_contents_observer_sanity_checker.h - Issue 1151973005: Bring RFH/RVH unit tests closer to reality of how RF/RV are initialized

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/web_contents_observer_sanity_checker.h

Issue 1151973005: Bring RFH/RVH unit tests closer to reality of how RF/RV are initialized (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix IsRenderFrameLive to be independent of RenderViewHost. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/test/test_render_view_host.cc ('K') | « content/test/test_web_contents.cc ('k') | content/test/web_contents_observer_sanity_checker.cc » ('j') | content/test/web_contents_observer_sanity_checker.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/test/web_contents_observer_sanity_checker.h

diff --git a/content/test/web_contents_observer_sanity_checker.h b/content/test/web_contents_observer_sanity_checker.h

index 940b6d216a4794cdbe57debc530c42aa7cfef96d..3c40a1b77b8412ba118ccba533649ca30d2cacf1 100644

--- a/content/test/web_contents_observer_sanity_checker.h

+++ b/content/test/web_contents_observer_sanity_checker.h

@@ -91,6 +91,9 @@ class WebContentsObserverSanityChecker : public WebContentsObserver,

std::set<std::pair<int, int>> live_routes_;

std::set<std::pair<int, int>> deleted_routes_;

+ base::hash_map<std::pair<int, int>, std::string> render_frame_created_stacks_;

+ base::hash_map<std::pair<int, int>, std::string> render_frame_deleted_stacks_;

bool web_contents_destroyed_;

DISALLOW_COPY_AND_ASSIGN(WebContentsObserverSanityChecker);