Bring RFH/RVH unit tests closer to reality of how RF/RV are initialized

content/test/test_render_view_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/test/test_render_view_host.h"
 
 #include "base/memory/scoped_ptr.h"
 #include "content/browser/dom_storage/dom_storage_context_wrapper.h"
 #include "content/browser/dom_storage/session_storage_namespace_impl.h"
 #include "content/browser/loader/resource_dispatcher_host_impl.h"
@@ skipping 228 matching lines @@
 bool TestRenderViewHost::CreateRenderView(
     const base::string16& frame_name,
     int opener_route_id,
     int proxy_route_id,
     int32 max_page_id,
     bool window_was_created_with_opener) {
   DCHECK(!IsRenderViewLive());
   set_renderer_initialized(true);
   DCHECK(IsRenderViewLive());
   opener_route_id_ = opener_route_id;
+  RenderFrameHost* main_frame = GetMainFrame();
+  if (main_frame)

[ncarter (slow), 2015/05/26 21:44:14]

When is this null? In RenderViewHostImpl's CreateRenderView it seems like this
call is done without checking for null.

[nasko, 2015/05/26 22:25:49]

This is in preparation for removing swapped out. When we want to create "swapped
out" object, in the next iteration we will be creating just a
RenderFrameProxyHost and the RenderViewHost will not have an associated main
frame.

+    static_cast<RenderFrameHostImpl*>(main_frame)->SetRenderFrameCreated(true);
+
   return true;
 }
 
 bool TestRenderViewHost::IsFullscreenGranted() const {
   return RenderViewHostImpl::IsFullscreenGranted();
 }
 
 MockRenderProcessHost* TestRenderViewHost::GetProcess() const {
   return static_cast<MockRenderProcessHost*>(RenderViewHostImpl::GetProcess());
 }
@@ skipping 54 matching lines @@
 
 TestRenderFrameHost* RenderViewHostImplTestHarness::main_test_rfh() {
   return contents()->GetMainFrame();
 }
 
 TestWebContents* RenderViewHostImplTestHarness::contents() {
   return static_cast<TestWebContents*>(web_contents());
 }
 
 }  // namespace content