Bring RFH/RVH unit tests closer to reality of how RF/RV are initialized

content/browser/frame_host/render_frame_host_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_frame_host_impl.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/containers/hash_tables.h"
 #include "base/lazy_instance.h"
@@ skipping 627 matching lines @@
   // The renderer now has a RenderFrame for this RenderFrameHost.  Note that
   // this path is only used for out-of-process iframes.  Main frame RenderFrames
   // are created with their RenderView, and same-site iframes are created at the
   // time of OnCreateChildFrame.
   SetRenderFrameCreated(true);
 
   return true;
 }
 
 bool RenderFrameHostImpl::IsRenderFrameLive() {
-  // RenderFrames are created for main frames at the same time as RenderViews,
-  // so we rely on IsRenderViewLive.  For subframes, we keep track of each
-  // RenderFrame individually with render_frame_created_.
-  bool is_live = !GetParent() ?
-      render_view_host_->IsRenderViewLive() :
-      GetProcess()->HasConnection() && render_frame_created_;
+  bool is_live = GetProcess()->HasConnection() && render_frame_created_;
+
+  // If the process is for an isolated guest (e.g. <webview>), rely on the
+  // RenderViewHost liveness check. Once https://crbug.com/492830 is fixed,
+  // this can be removed.
+  if (GetProcess()->IsIsolatedGuest())
+    is_live = render_view_host_->IsRenderViewLive();

[ncarter (slow), 2015/05/29 00:01:18]

If we're preserving the behavior of this function only for <webview>, does this
need to consider !GetParent() too?

[nasko, 2015/05/29 00:03:20]

Not really. We don't support any cross-process navigations in guests, so the
RenderViewHost is one for all frames. Any frame in such a process should key off
of the RenderViewHost.

 
   // Sanity check: the RenderView should always be live if the RenderFrame is.
   DCHECK(!is_live || render_view_host_->IsRenderViewLive());
 
   return is_live;
 }
 
 void RenderFrameHostImpl::SetRenderFrameCreated(bool created) {
   bool was_created = render_frame_created_;
   render_frame_created_ = created;
@@ skipping 1407 matching lines @@
   // We may be returning to an existing NavigationEntry that had been granted
   // file access.  If this is a different process, we will need to grant the
   // access again.  The files listed in the page state are validated when they
   // are received from the renderer to prevent abuse.
   if (request_params.page_state.IsValid()) {
     render_view_host_->GrantFileAccessFromPageState(request_params.page_state);
   }
 }
 
 }  // namespace content