Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1151933002: Remove Skia comment API overrides (Closed)

Created:
5 years, 7 months ago by f(malita)
Modified:
5 years, 6 months ago
Reviewers:
caseq, pfeldman, reed1
CC:
blink-reviews, krit, caseq+blink_chromium.org, pdr+graphicswatchlist_chromium.org, dshwang, yurys+blink_chromium.org, lushnikov+blink_chromium.org, jbroman, danakj, pfeldman+blink_chromium.org, Rik, apavlov+blink_chromium.org, Justin Novosad, devtools-reviews_chromium.org, f(malita), sergeyv+blink_chromium.org, rwlbuis, Stephen Chennney, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove Skia comment API overrides Blink is no longer emitting comment API calls, and the Skia interface is scheduled for removal. R=reed@google.com,caseq@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197127

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -48 lines) Patch
M Source/platform/graphics/InterceptingCanvas.h View 2 chunks +0 lines, -21 lines 0 comments Download
M Source/platform/graphics/LoggingCanvas.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/platform/graphics/LoggingCanvas.cpp View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
f(malita)
5 years, 7 months ago (2015-05-21 19:51:43 UTC) #1
reed1
lgtm
5 years, 7 months ago (2015-05-21 21:13:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151933002/1
5 years, 7 months ago (2015-05-22 14:29:39 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/33685)
5 years, 7 months ago (2015-05-22 14:36:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151933002/20001
5 years, 6 months ago (2015-06-15 16:34:03 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-15 17:35:06 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197127

Powered by Google App Engine
This is Rietveld 408576698