Issue 11519049: Validate that a single library has the same name as the package.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11519049: Validate that a single library has the same name as the package. (Closed)

Created:
8 years ago by nweiz

Modified:
8 years ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Validate that a single library has the same name as the package. BUG=7045 Committed: https://code.google.com/p/dart/source/detail?r=16139

Patch Set 1 #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -8 lines)			Patch
	M	utils/pub/validator/name.dart	View		1 chunk	+17 lines, -6 lines	1 comment	Download
	M	utils/tests/pub/validator_test.dart	View		3 chunks	+11 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

8 years ago (2012-12-13 19:52:32 UTC) #2

I think I would prefer that we didn't warn on this, but I know you feel
otherwise. One suggestion, but LGTM.

https://codereview.chromium.org/11519049/diff/1/utils/pub/validator/name.dart
File utils/pub/validator/name.dart (right):

https://codereview.chromium.org/11519049/diff/1/utils/pub/validator/name.dart...
utils/pub/validator/name.dart:38: });
How about splitting this out into a separate function? It would be nice if there
was a single canonicalize place in code for "get the list of public libraries in
the package".

Expand Messages | Collapse Messages