Issue 11519029: Do not read document and URL properties on global objects while taking heap snapshot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11519029: Do not read document and URL properties on global objects while taking heap snapshot (Closed)

Created:
8 years ago by yurys

Modified:
8 years ago

Reviewers:
Yang, Michael Starzinger, loislo

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Do not read document and URL properties on global objects while taking heap snapshot This unsafe mechanism was replaced with a user provided callback in r13137 and now we should remove old code. Committed: https://code.google.com/p/v8/source/detail?r=13203

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -72 lines)			Patch
	M	src/profile-generator.cc	View		2 chunks	+0 lines, -22 lines	0 comments	Download
	M	test/cctest/test-heap-profiler.cc	View		1 chunk	+0 lines, -50 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

8 years ago (2012-12-12 09:40:51 UTC) #3

On 2012/12/12 09:38:58, Michael Starzinger wrote:
> An all-red CL, that is an instant-LGTM from my end. :)

LGTM.

Expand Messages | Collapse Messages