Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1151853003: [strong] create strong array literals

Created:
5 years, 7 months ago by rossberg
Modified:
5 years, 6 months ago
CC:
v8-dev, arv (Not doing code reviews), conradw
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[strong] create strong array literals R=dslomov@chromium.org BUG=v8:3956 LOG=N

Patch Set 1 #

Patch Set 2 : Test spread arrays too #

Patch Set 3 : Rebase on fix #

Patch Set 4 : Rebase #

Patch Set 5 : Platform ports #

Patch Set 6 : Being stoopid #

Patch Set 7 : Introduce ObjectStrength enum for robustness #

Patch Set 8 : Fix a test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+336 lines, -231 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 3 4 5 6 2 chunks +7 lines, -6 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 3 4 5 6 3 chunks +17 lines, -14 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M src/builtins.cc View 1 2 3 4 5 6 1 chunk +2 lines, -4 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 2 3 4 5 6 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/factory.h View 1 2 3 4 5 6 2 chunks +8 lines, -3 lines 0 comments Download
M src/factory.cc View 1 2 3 4 5 6 3 chunks +12 lines, -7 lines 0 comments Download
M src/full-codegen.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/globals.h View 1 2 3 4 5 6 2 chunks +10 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 3 4 5 6 2 chunks +7 lines, -6 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M src/isolate.h View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 2 3 4 5 6 2 chunks +7 lines, -6 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 2 3 4 5 6 2 chunks +7 lines, -6 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M src/objects.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 1 2 3 4 5 6 3 chunks +12 lines, -6 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 4 5 6 3 chunks +6 lines, -5 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 1 2 3 4 5 6 7 4 chunks +6 lines, -4 lines 0 comments Download
M test/mjsunit/strong/literals.js View 1 3 chunks +206 lines, -146 lines 0 comments Download

Messages

Total messages: 35 (20 generated)
rossberg
5 years, 7 months ago (2015-05-21 16:00:35 UTC) #1
Dmitry Lomov (no reviews)
lgtm
5 years, 7 months ago (2015-05-21 17:15:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151853003/20001
5 years, 7 months ago (2015-05-21 17:20:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/627)
5 years, 7 months ago (2015-05-21 17:24:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151853003/60001
5 years, 7 months ago (2015-05-22 11:20:16 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/655)
5 years, 7 months ago (2015-05-22 11:42:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151853003/80001
5 years, 7 months ago (2015-05-22 13:15:53 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/678)
5 years, 7 months ago (2015-05-22 13:35:40 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151853003/100001
5 years, 7 months ago (2015-05-22 14:25:09 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/684)
5 years, 7 months ago (2015-05-22 14:41:41 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151853003/80002
5 years, 7 months ago (2015-05-22 15:46:04 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/687)
5 years, 7 months ago (2015-05-22 15:50:29 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151853003/130001
5 years, 7 months ago (2015-05-22 16:01:57 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/2982)
5 years, 7 months ago (2015-05-22 16:12:37 UTC) #32
conradw
5 years, 6 months ago (2015-05-28 14:18:25 UTC) #34 
With permission, I've fixed the remaining problems with this CL here:
https://codereview.chromium.org/1152093003/

Powered by Google App Engine
This is Rietveld 408576698