Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: net/http/http_auth_filter.h

Issue 1151843002: DO NOT LAND Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_auth_filter.h
diff --git a/net/http/http_auth_filter.h b/net/http/http_auth_filter.h
index 260da47c16d1832189e498e7f98ee0c7c57ff84a..039f25fdc50e28b114d64081acc281777619bb71 100644
--- a/net/http/http_auth_filter.h
+++ b/net/http/http_auth_filter.h
@@ -22,9 +22,10 @@ class NET_EXPORT_PRIVATE HttpAuthFilter {
public:
virtual ~HttpAuthFilter() {}
- // Checks if (|url|, |target|) is supported by the authentication scheme.
- // Only the host of |url| is examined.
- virtual bool IsValid(const GURL& url, HttpAuth::Target target) const = 0;
+ // Checks if (|origin|, |target|) is supported by the authentication scheme.
+ // Only the host of |origin| is examined.
+ virtual bool IsValid(const url::Origin& origin,
+ HttpAuth::Target target) const = 0;
};
// Whitelist HTTP authentication filter.
@@ -46,7 +47,8 @@ class NET_EXPORT HttpAuthFilterWhitelist : public HttpAuthFilter {
const ProxyBypassRules& rules() const { return rules_; }
// HttpAuthFilter methods:
- bool IsValid(const GURL& url, HttpAuth::Target target) const override;
+ bool IsValid(const url::Origin& origin,
+ HttpAuth::Target target) const override;
private:
// Installs the whitelist.

Powered by Google App Engine
This is Rietveld 408576698