DO NOT LAND

net/ftp/ftp_auth_cache.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_FTP_FTP_AUTH_CACHE_H_
 #define NET_FTP_FTP_AUTH_CACHE_H_
 
 #include <list>
 
 #include "net/base/auth.h"
 #include "net/base/net_export.h"
-#include "url/gurl.h"
+#include "url/origin.h"
 
 namespace net {
 
 // The FtpAuthCache class is a simple cache structure to store authentication
 // information for ftp. Provides lookup, insertion, and deletion of entries.
 // The parameter for doing lookups, insertions, and deletions is a GURL of the
 // server's address (not a full URL with path, since FTP auth isn't per path).
 // For example:
 //   GURL("ftp://myserver") -- OK (implied port of 21)
 //   GURL("ftp://myserver:21") -- OK
 //   GURL("ftp://myserver/PATH") -- WRONG, paths not allowed
 class NET_EXPORT_PRIVATE FtpAuthCache {
  public:
   // Maximum number of entries we allow in the cache.
   static const size_t kMaxEntries;
 
   struct Entry {
-    Entry(const GURL& origin, const AuthCredentials& credentials);
+    Entry(const url::Origin& origin, const AuthCredentials& credentials);
     ~Entry();
 
-    GURL origin;
+    url::Origin origin;
     AuthCredentials credentials;
   };
 
   FtpAuthCache();
   ~FtpAuthCache();
 
   // Return Entry corresponding to given |origin| or NULL if not found.
-  Entry* Lookup(const GURL& origin);
+  Entry* Lookup(const url::Origin& origin);
 
   // Add an entry for |origin| to the cache using |credentials|. If there is
   // already an entry for |origin|, it will be overwritten.
-  void Add(const GURL& origin, const AuthCredentials& credentials);
+  void Add(const url::Origin& origin, const AuthCredentials& credentials);
 
   // Remove the entry for |origin| from the cache, if one exists and matches
   // |credentials|.
-  void Remove(const GURL& origin, const AuthCredentials& credentials);
+  void Remove(const url::Origin& origin, const AuthCredentials& credentials);

[Ryan Sleevi, 2015/05/22 02:50:03]

So, overall, changes like this make me... Generally nervous. And I guess this
probably highlights some of my unease re: url::Origin

Yes, if you get rid of GURL::GetOrigin(), then this is necessary. But this comes
with it a non-trivial, subtle behaviour change that has to be evaluated on a
case by case basis. That is, we have to make sure that you can't pass a 'null'
origin here, or someone could flood the cache. In the existing behaviour, all
such invalid origins would collapse into a single origin.

You can argue it's good ("but they COULD BE different") or bad (if anyone can
get junk in, they can do a DoS)

That's why I'm nervous about the overall approach. I absolutely don't think a
bombing run like this can be rubberstamped - every one of these calls has to be
checked for callers to see if they're handling user input, if bad origins could
be provided, what the expectations are, etc.

 
  private:
   typedef std::list<Entry> EntryList;
 
   // Internal representation of cache, an STL list. This makes lookups O(n),
   // but we expect n to be very low.
   EntryList entries_;
 };
 
 }  // namespace net
 
 #endif  // NET_FTP_FTP_AUTH_CACHE_H_