Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 1151833004: Remove ERR_SSL_UNSAFE_NEGOTIATION error code. (Closed)

Created:
5 years, 6 months ago by davidben
Modified:
5 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, android-webview-reviews_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ERR_SSL_UNSAFE_NEGOTIATION error code. Let them map to the default ERR_SSL_PROTOCOL_ERROR. It was added, along with a custom error message, in https://crrev.com/51258. The enforcement was then removed in https://codereview.chromium.org/6792032, but the error code and custom message remained. Prune them; the error is now unreachable but for some codepaths in NSS (server originally supported RI and renego without it) and the custom error message is now innaccurate. BUG=none Committed: https://crrev.com/9a38456c11f5f6031e6710e958f7838e978ee05d Cr-Commit-Position: refs/heads/master@{#332125}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -20 lines) Patch
M android_webview/java/src/org/chromium/android_webview/ErrorCodeConversionHelper.java View 1 chunk +0 lines, -1 line 0 comments Download
M build/ios/grit_whitelist.txt View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/localized_error.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M net/base/net_error_list.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/socket/nss_ssl_util.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/ssl/openssl_ssl_util.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
davidben
5 years, 6 months ago (2015-05-29 20:42:39 UTC) #2
agl
lgtm
5 years, 6 months ago (2015-05-29 21:12:36 UTC) #3
davidben
+sgurun for android_webview +jhawkins for chrome/common/localized_error.cc
5 years, 6 months ago (2015-05-29 21:18:38 UTC) #5
sgurun-gerrit only
On 2015/05/29 21:18:38, David Benjamin wrote: > +sgurun for android_webview > +jhawkins for chrome/common/localized_error.cc aw ...
5 years, 6 months ago (2015-05-29 21:24:33 UTC) #6
James Hawkins
lgtm
5 years, 6 months ago (2015-05-30 05:13:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151833004/1
5 years, 6 months ago (2015-05-30 18:31:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-05-30 18:34:36 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-05-30 18:35:28 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a38456c11f5f6031e6710e958f7838e978ee05d
Cr-Commit-Position: refs/heads/master@{#332125}

Powered by Google App Engine
This is Rietveld 408576698