Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 1151783003: Workaround qualcomm-specific activity restore bug (Closed)

Created:
5 years, 7 months ago by boliu
Modified:
5 years, 6 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Workaround qualcomm-specific activity restore bug When an activity containing hardware webview is restored from a different activity in the process, corruption happens, appearing to be caused by some persistent buffer failing to persist. Workaround by force invalidating the whole view tree once an activity is restored. Limit original glBindRenderbufferEXT workaround to teardown (ie kModeProcess). This is still needed for when the restored activity contains no webview. Should be faster than previous implementation since it's not on every frame. BUG=434570 Committed: https://crrev.com/cd52509317c6ed6e345999ca1df81f46ac0a327f Cr-Commit-Position: refs/heads/master@{#331435}

Patch Set 1 #

Patch Set 2 : or #

Patch Set 3 : qc workaround on teardown #

Patch Set 4 : kProcess #

Patch Set 5 : smaller #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M android_webview/browser/scoped_app_gl_state_restore.cc View 1 2 3 4 1 chunk +5 lines, -2 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 2 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
boliu
5 years, 7 months ago (2015-05-23 00:40:32 UTC) #2
hush (inactive)
lgtm
5 years, 6 months ago (2015-05-26 17:33:17 UTC) #3
boliu
Please restamp PS4
5 years, 6 months ago (2015-05-26 19:17:46 UTC) #4
boliu
smaller change in PS5, as discussed
5 years, 6 months ago (2015-05-26 20:49:57 UTC) #5
hush (inactive)
lgtm
5 years, 6 months ago (2015-05-26 20:53:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151783003/80001
5 years, 6 months ago (2015-05-26 20:56:09 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 6 months ago (2015-05-26 21:10:16 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-05-26 21:11:02 UTC) #10
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/cd52509317c6ed6e345999ca1df81f46ac0a327f
Cr-Commit-Position: refs/heads/master@{#331435}

Powered by Google App Engine
This is Rietveld 408576698