Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 1151773007: Remove integrity attribute from elements not in SRI spec (Closed)

Created:
5 years, 6 months ago by jww
Modified:
5 years, 6 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, feature-media-reviews_chromium.org, philipj_slow, arv+blink, vivekg_samsung, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, vivekg, dglazkov+blink, nessy, Inactive, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove integrity attribute from elements not in SRI spec Initially, it was anticipated that Subresource Integrity would cover many more elements than the current version of the spec covers. While many elements may be added in a future version of the spec, this CL removes them since they are unspec'd and unimplemented. BUG=355467 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196272

Patch Set 1 #

Patch Set 2 : Test fixes #

Patch Set 3 : Update test results #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -78 lines) Patch
M LayoutTests/fast/dom/plugin-attributes-enumeration-expected.txt View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/subresourceIntegrity/integrity-attribute.html View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/http/tests/security/subresourceIntegrity/integrity-attribute-expected.txt View 1 chunk +9 lines, -9 lines 0 comments Download
M LayoutTests/webexposed/element-instance-property-listing-expected.txt View 1 10 chunks +0 lines, -10 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 11 chunks +0 lines, -12 lines 0 comments Download
M Source/core/html/HTMLAnchorElement.idl View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/HTMLEmbedElement.idl View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/HTMLIFrameElement.idl View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/HTMLImageElement.idl View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/HTMLMediaElement.idl View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/HTMLObjectElement.idl View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/HTMLSourceElement.idl View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/HTMLTrackElement.idl View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
jww
Hi Philip. This removes the integrity attribute from the elements not in the SRI spec, ...
5 years, 6 months ago (2015-06-01 16:45:36 UTC) #2
philipj_slow
LGTM, but you'll have to update some expectations in LayoutTests/webexposed/ and LayoutTests/virtual/stable/webexposed/ too.
5 years, 6 months ago (2015-06-01 18:00:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151773007/20001
5 years, 6 months ago (2015-06-01 18:41:39 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/64236)
5 years, 6 months ago (2015-06-01 19:52:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151773007/20001
5 years, 6 months ago (2015-06-01 20:42:15 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/64643)
5 years, 6 months ago (2015-06-01 23:35:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151773007/40001
5 years, 6 months ago (2015-06-02 00:27:45 UTC) #15
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 01:51:24 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196272

Powered by Google App Engine
This is Rietveld 408576698