[Autofill] remove *MultiInfo* functions

[Autofill] remove *MultiInfo* functions

BUG=493856
Committed: https://crrev.com/75713f0d6d887890bb4773e522bcdb3cb3e328be
Cr-Commit-Position: refs/heads/master@{#333204}

[Evan Stade, 2015-06-05 21:55:50]

estade@chromium.org changed reviewers:
+ khorimoto@chromium.org, rouslan@chromium.org

[please use gerrit instead, 2015-06-05 22:21:06]

https://codereview.chromium.org/1151763013/diff/1/components/autofill/core/br...
File components/autofill/core/browser/webdata/autofill_table.cc (right):

https://codereview.chromium.org/1151763013/diff/1/components/autofill/core/br...
components/autofill/core/browser/webdata/autofill_table.cc:280: bool
AddAutofillProfileNames(const AutofillProfile& profile,
From my understanding of this code, AddAutofillProfileNames() appends names to
the bottom of the table, but AddAutofillProfileNamesToProfile() reads only the
top row. Is that right? That would make AddAutofillProfileNames() appear to be a
no-op after the first call. This is a good candidate for a new
AutofillTableTest.

[Kyle Horimoto, 2015-06-05 22:21:46]

lgtm

[Evan Stade, 2015-06-05 22:48:02]

https://codereview.chromium.org/1151763013/diff/1/components/autofill/core/br...
File components/autofill/core/browser/webdata/autofill_table.cc (right):

https://codereview.chromium.org/1151763013/diff/1/components/autofill/core/br...
components/autofill/core/browser/webdata/autofill_table.cc:280: bool
AddAutofillProfileNames(const AutofillProfile& profile,
On 2015/06/05 22:21:06, Rouslan wrote:
> From my understanding of this code, AddAutofillProfileNames() appends names to
> the bottom of the table, but AddAutofillProfileNamesToProfile() reads only the
> top row. Is that right? That would make AddAutofillProfileNames() appear to be
a
> no-op after the first call. This is a good candidate for a new
> AutofillTableTest. 

It's only called once. This was true before and after this patch. Before, if it
had been called multiple times, we'd have been duplicating names.

[please use gerrit instead, 2015-06-05 23:21:46]

in that case, lgtm

[Evan Stade, 2015-06-06 01:11:53]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2015-06-06 01:11:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
khorimoto@chromium.org, rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/1151763013/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2015-06-06 01:12:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1151763013/20001

[commit-bot: I haz the power, 2015-06-06 02:06:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-06 02:07:04]

Patchset 2 (id:??) landed as
https://crrev.com/75713f0d6d887890bb4773e522bcdb3cb3e328be
Cr-Commit-Position: refs/heads/master@{#333204}