Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: chrome/browser/chromeos/file_system_provider/operations/get_actions_unittest.cc

Issue 1151763007: Add the boilerplate for actions to File System Provider API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/file_system_provider/operations/get_actions_unittest.cc
diff --git a/chrome/browser/chromeos/file_system_provider/operations/get_actions_unittest.cc b/chrome/browser/chromeos/file_system_provider/operations/get_actions_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..d06df2b3df5ff7d65e56bd159f8239a850071bb5
--- /dev/null
+++ b/chrome/browser/chromeos/file_system_provider/operations/get_actions_unittest.cc
@@ -0,0 +1,235 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/chromeos/file_system_provider/operations/get_actions.h"
+
+#include <string>
+
+#include "base/files/file.h"
+#include "base/files/file_path.h"
+#include "base/json/json_reader.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/memory/scoped_vector.h"
+#include "base/values.h"
+#include "chrome/browser/chromeos/file_system_provider/operations/get_metadata.h"
+#include "chrome/browser/chromeos/file_system_provider/operations/test_util.h"
+#include "chrome/common/extensions/api/file_system_provider.h"
+#include "chrome/common/extensions/api/file_system_provider_capabilities/file_system_provider_capabilities_handler.h"
+#include "chrome/common/extensions/api/file_system_provider_internal.h"
+#include "extensions/browser/event_router.h"
+#include "storage/browser/fileapi/async_file_util.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace chromeos {
+namespace file_system_provider {
+namespace operations {
+namespace {
+
+const char kExtensionId[] = "mbflcebpggnecokmikipoihdbecnjfoj";
+const char kFileSystemId[] = "testing-file-system";
+const int kRequestId = 2;
+const base::FilePath::CharType kEntryPath[] = FILE_PATH_LITERAL("/directory");
+
+// Callback invocation logger. Acts as a fileapi end-point.
+class CallbackLogger {
+ public:
+ class Event {
+ public:
+ Event(const Actions& actions, base::File::Error result)
+ : actions_(actions), result_(result) {}
+ virtual ~Event() {}
+
+ const Actions& actions() const { return actions_; }
+ base::File::Error result() const { return result_; }
+
+ private:
+ Actions actions_;
+ base::File::Error result_;
+
+ DISALLOW_COPY_AND_ASSIGN(Event);
+ };
+
+ CallbackLogger() {}
+ virtual ~CallbackLogger() {}
+
+ void OnGetActions(const Actions& actions, base::File::Error result) {
+ events_.push_back(new Event(actions, result));
+ }
+
+ const ScopedVector<Event>& events() const { return events_; }
+
+ private:
+ ScopedVector<Event> events_;
+
+ DISALLOW_COPY_AND_ASSIGN(CallbackLogger);
+};
+
+// Returns the request value as |result| in case of successful parse.
+void CreateRequestValueFromJSON(const std::string& json,
+ scoped_ptr<RequestValue>* result) {
+ using extensions::api::file_system_provider_internal::
+ GetActionsRequestedSuccess::Params;
+
+ int json_error_code;
+ std::string json_error_msg;
+ scoped_ptr<base::Value> value = base::JSONReader::ReadAndReturnError(
+ json, base::JSON_PARSE_RFC, &json_error_code, &json_error_msg);
+ ASSERT_TRUE(value.get()) << json_error_msg;
+
+ base::ListValue* value_as_list;
+ ASSERT_TRUE(value->GetAsList(&value_as_list));
+ scoped_ptr<Params> params(Params::Create(*value_as_list));
+ ASSERT_TRUE(params.get());
+ *result = RequestValue::CreateForGetActionsSuccess(params.Pass());
+ ASSERT_TRUE(result->get());
+}
+
+} // namespace
+
+class FileSystemProviderOperationsGetActionsTest : public testing::Test {
+ protected:
+ FileSystemProviderOperationsGetActionsTest() {}
+ ~FileSystemProviderOperationsGetActionsTest() override {}
+
+ void SetUp() override {
+ file_system_info_ = ProvidedFileSystemInfo(
+ kExtensionId, MountOptions(kFileSystemId, "" /* display_name */),
+ base::FilePath(), false /* configurable */, extensions::SOURCE_FILE);
+ }
+
+ ProvidedFileSystemInfo file_system_info_;
+};
+
+TEST_F(FileSystemProviderOperationsGetActionsTest, Execute) {
+ using extensions::api::file_system_provider::GetActionsRequestedOptions;
+
+ util::LoggingDispatchEventImpl dispatcher(true /* dispatch_reply */);
+ CallbackLogger callback_logger;
+
+ GetActions get_actions(NULL, file_system_info_, base::FilePath(kEntryPath),
+ base::Bind(&CallbackLogger::OnGetActions,
+ base::Unretained(&callback_logger)));
+ get_actions.SetDispatchEventImplForTesting(
+ base::Bind(&util::LoggingDispatchEventImpl::OnDispatchEventImpl,
+ base::Unretained(&dispatcher)));
+
+ EXPECT_TRUE(get_actions.Execute(kRequestId));
+
+ ASSERT_EQ(1u, dispatcher.events().size());
+ extensions::Event* event = dispatcher.events()[0];
+ EXPECT_EQ(
+ extensions::api::file_system_provider::OnGetActionsRequested::kEventName,
+ event->event_name);
+ base::ListValue* event_args = event->event_args.get();
+ ASSERT_EQ(1u, event_args->GetSize());
+
+ const base::DictionaryValue* options_as_value = NULL;
+ ASSERT_TRUE(event_args->GetDictionary(0, &options_as_value));
+
+ GetActionsRequestedOptions options;
+ ASSERT_TRUE(
+ GetActionsRequestedOptions::Populate(*options_as_value, &options));
+ EXPECT_EQ(kFileSystemId, options.file_system_id);
+ EXPECT_EQ(kRequestId, options.request_id);
+ EXPECT_EQ(kEntryPath, options.entry_path);
+}
+
+TEST_F(FileSystemProviderOperationsGetActionsTest, Execute_NoListener) {
+ util::LoggingDispatchEventImpl dispatcher(false /* dispatch_reply */);
+ CallbackLogger callback_logger;
+
+ GetActions get_actions(NULL, file_system_info_, base::FilePath(kEntryPath),
+ base::Bind(&CallbackLogger::OnGetActions,
+ base::Unretained(&callback_logger)));
+ get_actions.SetDispatchEventImplForTesting(
+ base::Bind(&util::LoggingDispatchEventImpl::OnDispatchEventImpl,
+ base::Unretained(&dispatcher)));
+
+ EXPECT_FALSE(get_actions.Execute(kRequestId));
+}
+
+TEST_F(FileSystemProviderOperationsGetActionsTest, OnSuccess) {
+ util::LoggingDispatchEventImpl dispatcher(true /* dispatch_reply */);
+ CallbackLogger callback_logger;
+
+ GetActions get_actions(NULL, file_system_info_, base::FilePath(kEntryPath),
+ base::Bind(&CallbackLogger::OnGetActions,
+ base::Unretained(&callback_logger)));
+ get_actions.SetDispatchEventImplForTesting(
+ base::Bind(&util::LoggingDispatchEventImpl::OnDispatchEventImpl,
+ base::Unretained(&dispatcher)));
+
+ EXPECT_TRUE(get_actions.Execute(kRequestId));
+
+ // Sample input as JSON. Keep in sync with file_system_provider_api.idl.
+ // As for now, it is impossible to create *::Params class directly, not from
+ // base::Value.
+ const std::string input =
+ "[\n"
+ " \"testing-file-system\",\n" // kFileSystemId
+ " 2,\n" // kRequestId
+ " [\n"
+ " {\n"
+ " \"id\": \"SAVE_FOR_OFFLINE\"\n"
+ " },\n"
+ " {\n"
+ " \"id\": \"OFFLINE_NOT_NECESSARY\",\n"
+ " \"title\": \"Ignored title.\"\n"
+ " },\n"
+ " {\n"
+ " \"id\": \"SomeCustomActionId\",\n"
+ " \"title\": \"Custom action.\"\n"
+ " }\n"
+ " ],\n"
+ " 0\n" // execution_time
+ "]\n";
+ scoped_ptr<RequestValue> request_value;
+ ASSERT_NO_FATAL_FAILURE(CreateRequestValueFromJSON(input, &request_value));
+
+ const bool has_more = false;
+ get_actions.OnSuccess(kRequestId, request_value.Pass(), has_more);
+
+ ASSERT_EQ(1u, callback_logger.events().size());
+ CallbackLogger::Event* event = callback_logger.events()[0];
+ EXPECT_EQ(base::File::FILE_OK, event->result());
+
+ ASSERT_EQ(3u, event->actions().size());
+ const Action action_share = event->actions()[0];
+ EXPECT_EQ("SAVE_FOR_OFFLINE", action_share.id);
+ EXPECT_EQ("", action_share.title);
+
+ const Action action_pin_toggle = event->actions()[1];
+ EXPECT_EQ("OFFLINE_NOT_NECESSARY", action_pin_toggle.id);
+ EXPECT_EQ("Ignored title.", action_pin_toggle.title);
+
+ const Action action_custom = event->actions()[2];
+ EXPECT_EQ("SomeCustomActionId", action_custom.id);
+ EXPECT_EQ("Custom action.", action_custom.title);
+}
+
+TEST_F(FileSystemProviderOperationsGetActionsTest, OnError) {
+ util::LoggingDispatchEventImpl dispatcher(true /* dispatch_reply */);
+ CallbackLogger callback_logger;
+
+ GetActions get_actions(NULL, file_system_info_, base::FilePath(kEntryPath),
+ base::Bind(&CallbackLogger::OnGetActions,
+ base::Unretained(&callback_logger)));
+ get_actions.SetDispatchEventImplForTesting(
+ base::Bind(&util::LoggingDispatchEventImpl::OnDispatchEventImpl,
+ base::Unretained(&dispatcher)));
+
+ EXPECT_TRUE(get_actions.Execute(kRequestId));
+
+ get_actions.OnError(kRequestId, scoped_ptr<RequestValue>(new RequestValue()),
+ base::File::FILE_ERROR_TOO_MANY_OPENED);
+
+ ASSERT_EQ(1u, callback_logger.events().size());
+ CallbackLogger::Event* event = callback_logger.events()[0];
+ EXPECT_EQ(base::File::FILE_ERROR_TOO_MANY_OPENED, event->result());
+ ASSERT_EQ(0u, event->actions().size());
+}
+
+} // namespace operations
+} // namespace file_system_provider
+} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698