Add Sky framework support for drawing images

sky/engine/core/loader/NewImageLoader.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef SKY_ENGINE_CORE_LOADER_NEWIMAGELOADER_H_
+#define SKY_ENGINE_CORE_LOADER_NEWIMAGELOADER_H_
+
+#include "mojo/common/data_pipe_drainer.h"
+#include "sky/engine/platform/SharedBuffer.h"
+#include "sky/engine/platform/fetcher/MojoFetcher.h"
+#include "sky/engine/wtf/OwnPtr.h"
+#include "sky/engine/wtf/PassOwnPtr.h"
+#include "sky/engine/wtf/text/AtomicString.h"
+#include "third_party/skia/include/core/SkBitmap.h"
+
+namespace blink {
+
+class NewImageLoaderClient {
+ public:
+  virtual void notifyLoadFinished(const SkBitmap& result) = 0;

[abarth-chromium, 2015/05/29 23:04:10]

I wonder if we should use the "On" pattern of naming these callbacks.  It's not
a big deal either way.

[jackson, 2015/05/29 23:35:43]

Acknowledged.

+
+ protected:
+  NewImageLoaderClient() {}
+};
+
+class NewImageLoader : public MojoFetcher::Client,
+                       public mojo::common::DataPipeDrainer::Client {
+ public:
+  static PassOwnPtr<NewImageLoader> create(NewImageLoaderClient* client) {
+    return adoptPtr(new NewImageLoader(client));
+  }

[abarth-chromium, 2015/05/29 23:04:10]

Is there a reason to have a |create| function?  Why not just make the
constructor public and let the caller decide whether they want to hold the
object by value or by pointer?

[jackson, 2015/05/29 23:35:44]

Acknowledged.

+  virtual ~NewImageLoader() {}

[abarth-chromium, 2015/05/29 23:04:10]

Implementations of virtual functions should be out-of-line.  (The compiler can't
do anything useful with them in the header because they can't be inlined
anyway.)

[jackson, 2015/05/29 23:35:44]

Acknowledged.

+
+  void Load(const KURL& src);
+
+  void OnReceivedResponse(mojo::URLResponsePtr);
+  void OnDataAvailable(const void*, size_t);
+  void OnDataComplete();

[abarth-chromium, 2015/05/29 23:04:10]

Please put the |override| keyword on these virtual function overrides.

[jackson, 2015/05/29 23:35:44]

Acknowledged.

+
+ protected:

[abarth-chromium, 2015/05/29 23:04:10]

Remove?

[jackson, 2015/05/29 23:35:44]

Acknowledged.

+ private:
+  explicit NewImageLoader(NewImageLoaderClient* client) : client_(client) {}
+
+  NewImageLoaderClient* client_;
+  OwnPtr<MojoFetcher> fetcher_;
+  OwnPtr<mojo::common::DataPipeDrainer> drainer_;
+  RefPtr<SharedBuffer> buffer_;
+};
+}

[abarth-chromium, 2015/05/29 23:04:10]

}  // namespace blink

Also, once you make that change, |git cl format| will want a blank line before
this line.

[jackson, 2015/05/29 23:35:44]

Acknowledged.

+
+#endif  // SKY_ENGINE_CORE_LOADER_NEWIMAGELOADER_H_