Integration test for Chrome-Proxy: pass-through directive

tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/pass_through.py

+# Copyright 2015 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+from telemetry.page import page as page_module
+from telemetry.page import page_set as page_set_module
+
+class PassThroughPage(page_module.Page):
+  """
+  A test page for the chrome proxy pass-through tests.
+  """
+
+  def __init__(self, url, page_set):
+    super(PassThroughPage, self).__init__(url=url, page_set=page_set)
+
+  def RunNavigateSteps(self, action_runner):
+    super(PassThroughPage, self).RunNavigateSteps(action_runner)
+    action_runner.ExecuteJavaScript('''
+        (function() {
+          var request = new XMLHttpRequest();
+          request.open("GET", "http://aws1.mdw.la/fw/buddy.jpg");

[sclittle, 2015/05/21 01:54:24]

Also, don't hardcode the url here, just use |self.url|.

[sclittle, 2015/05/21 01:54:25]

Please use something off of check.googlezip.net, we're trying to eliminate any
usage of aws1.mdw.la from the tests.

e.g. http://check.googlezip.net/image.png

[megjablon, 2015/05/21 19:03:07]

Done.

+          request.setRequestHeader("Chrome-Proxy","pass-through");

[sclittle, 2015/05/21 01:54:25]

nit: add space after comma

[Not at Google. Contact bengr, 2015/05/21 18:29:00]

For this test to be meaningful, "Chrome-Proxy: pass-through" should be added by
Chrome and not by this test. If some bug causes Chrome to start sending the
wrong header, this test would still pass.

[sclittle, 2015/05/21 18:43:05]

@kundaji:

IIRC the "Chrome-Proxy: pass-through" request header would be added when a user
clicks "Reload original image" or something in the context menu after
long-pressing an image. We should have a browser test for that, but I don't
think it's possible to trigger that action through Telemetry.

IIUC the idea is that (browser test for using the context menu to reload
original image causes Chrome to send "pass-through") + (this telemetry test for
"pass-through") = fully tested.

You're right that this test doesn't test the full DRP client behavior, and
ideally we'd have an integration test doing the whole thing together from the
context menu and talking to the real DRP, but I think this Javascript approach
is at least better than adding a new Chrome command line flag just for this test
that forces "Chrome-Proxy: pass-through".

WDYT?

[Not at Google. Contact bengr, 2015/05/21 18:53:54]

You are right: I forgot that Telemetry does not allow clicking menu options.
Given that we cannot force Chrome to send this header in an integration test,
the approach here is definitely better than nothing.

[megjablon, 2015/05/21 19:03:07]

Done.

+          request.send(null);
+        })();''')
+    action_runner.Wait(1)
+
+
+class PassThroughPageSet(page_set_module.PageSet):
+  """ Chrome proxy test sites """
+
+  def __init__(self):
+    super(PassThroughPageSet, self).__init__()
+
+    urls_list = [
+      'http://aws1.mdw.la/fw/buddy.jpg',

[sclittle, 2015/05/21 01:54:25]

same here, use http://check.googlezip.net/image.png or something instead of
aws1.mdw.la.

[megjablon, 2015/05/21 19:03:07]

Done.

+    ]
+
+    for url in urls_list:
+      self.AddUserStory(PassThroughPage(url, self))