Integration test for Chrome-Proxy: pass-through directive

tools/chrome_proxy/common/chrome_proxy_metrics.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 import time
 
 from common import network_metrics
 from telemetry.page import page_test
 from telemetry.value import scalar
@@ skipping 73 matching lines @@
     chrome_proxy_request_header = self.response.request_headers['Chrome-Proxy']
     values = [v.strip() for v in chrome_proxy_request_header.split(',')]
     return any(v == "q=low" for v in values)
 
   def HasChromeProxyLoFiResponse(self):
     chrome_proxy_response_header = self.response.GetHeader('Chrome-Proxy')
     if not chrome_proxy_response_header:
       return False
     values = [v.strip() for v in chrome_proxy_response_header.split(',')]
     return any(v == "q=low" for v in values)
+
+  def HasChromeProxyPassThroughRequest(self):
+    if 'Chrome-Proxy' not in self.response.request_headers:
+      return False
+    chrome_proxy_request_header = self.response.request_headers['Chrome-Proxy']

[sclittle, 2015/05/21 01:54:24]

This code to extract a value from a header seems to be duplicated in a bunch of
places here, could you pull it out to a helper function?

[megjablon, 2015/05/21 19:03:07]

WDYT?

[sclittle, 2015/05/21 19:28:56]

Looks good, thanks!

+    values = [v.strip() for v in chrome_proxy_request_header.split(',')]
+    return any(v == "pass-through" for v in values)