Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 1151633003: Remove SkDrawPictureCallback (Closed)

Created:
5 years, 7 months ago by f(malita)
Modified:
5 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SkDrawPictureCallback No longer used in Chromium. R=reed@google.com [mtklein mischief] No one objects to removing dead API... TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/fd674ddbd6cf403ce009de58c1ba4b2bb660e9ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -34 lines) Patch
D include/core/SkDrawPictureCallback.h View 1 chunk +0 lines, -34 lines 0 comments Download

Messages

Total messages: 18 (5 generated)
f(malita)
5 years, 7 months ago (2015-05-21 19:05:07 UTC) #1
mtklein
Does this mean we can remove the whole abort-picture-playback-callback system?
5 years, 7 months ago (2015-05-21 19:10:10 UTC) #3
f(malita)
On 2015/05/21 19:10:10, mtklein wrote: > Does this mean we can remove the whole abort-picture-playback-callback ...
5 years, 7 months ago (2015-05-21 19:11:12 UTC) #4
f(malita)
On 2015/05/21 19:11:12, f(malita) wrote: > On 2015/05/21 19:10:10, mtklein wrote: > > Does this ...
5 years, 7 months ago (2015-05-21 19:12:28 UTC) #5
mtklein
Gotcha.
5 years, 7 months ago (2015-05-21 19:16:49 UTC) #6
f(malita)
Bump.
5 years, 6 months ago (2015-06-15 13:06:06 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151633003/1
5 years, 6 months ago (2015-06-15 13:06:23 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-15 13:11:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151633003/1
5 years, 6 months ago (2015-06-15 13:55:56 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/fd674ddbd6cf403ce009de58c1ba4b2bb660e9ab
5 years, 6 months ago (2015-06-15 13:56:27 UTC) #15
robertphillips
lgtm
5 years, 6 months ago (2015-06-15 14:20:36 UTC) #16
f(malita)
On 2015/06/15 at 14:20:36, robertphillips wrote: > lgtm How did the CQ land this one ...
5 years, 6 months ago (2015-06-15 15:00:28 UTC) #17
mtklein
5 years, 6 months ago (2015-06-15 15:38:30 UTC) #18
Message was sent while issue was closed.
On 2015/06/15 15:00:28, f(malita) wrote:
> On 2015/06/15 at 14:20:36, robertphillips wrote:
> > lgtm
> 
> How did the CQ land this one without a LGTM? :)

Oh, I TBR'd it.

Powered by Google App Engine
This is Rietveld 408576698