Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 1151613005: Port touch-demo.sky to SkyView universe (Closed)

Created:
5 years, 7 months ago by abarth-chromium
Modified:
5 years, 7 months ago
Reviewers:
eseidel, Hixie
CC:
Hixie, abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -0 lines) Patch
A sky/examples/raw/touch_demo.dart View 1 chunk +100 lines, -0 lines 4 comments Download

Messages

Total messages: 6 (1 generated)
abarth-chromium
5 years, 7 months ago (2015-05-21 17:51:21 UTC) #1
eseidel
lgtm https://codereview.chromium.org/1151613005/diff/1/sky/examples/raw/touch_demo.dart File sky/examples/raw/touch_demo.dart (right): https://codereview.chromium.org/1151613005/diff/1/sky/examples/raw/touch_demo.dart#newcode44 sky/examples/raw/touch_demo.dart:44: if (event.type == 'pointerdown') { Would be nice ...
5 years, 7 months ago (2015-05-21 17:54:45 UTC) #2
abarth-chromium
https://codereview.chromium.org/1151613005/diff/1/sky/examples/raw/touch_demo.dart File sky/examples/raw/touch_demo.dart (right): https://codereview.chromium.org/1151613005/diff/1/sky/examples/raw/touch_demo.dart#newcode44 sky/examples/raw/touch_demo.dart:44: if (event.type == 'pointerdown') { On 2015/05/21 at 17:54:45, ...
5 years, 7 months ago (2015-05-21 19:26:49 UTC) #3
abarth-chromium
Committed patchset #1 (id:1) manually as 91c4b174a2962841167dddd7460ee455076dde77 (presubmit successful).
5 years, 7 months ago (2015-05-21 19:34:42 UTC) #4
Hixie
5 years, 7 months ago (2015-05-21 19:47:07 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/1151613005/diff/1/sky/examples/raw/touch_demo...
File sky/examples/raw/touch_demo.dart (right):

https://codereview.chromium.org/1151613005/diff/1/sky/examples/raw/touch_demo...
sky/examples/raw/touch_demo.dart:44: if (event.type == 'pointerdown') {
On 2015/05/21 at 17:54:45, eseidel wrote:
> Would be nice to be able to handle these as an enum in a switch.  Not sure if
Dart helps you much there though.

eventually these will be class "is" expressions, which Dart definitely doesn't
do in a switch yet.

Powered by Google App Engine
This is Rietveld 408576698