Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2830)

Unified Diff: base/trace_event/process_memory_dump_unittest.cc

Issue 1151603004: [tracing] Add support to pre-load and merge ProcessMemoryDump(s). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: petrcermak nits Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/trace_event/process_memory_dump.cc ('k') | base/trace_event/trace_event.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/process_memory_dump_unittest.cc
diff --git a/base/trace_event/process_memory_dump_unittest.cc b/base/trace_event/process_memory_dump_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..d2915902988c3772f688ec0e85e9f33472c13bba
--- /dev/null
+++ b/base/trace_event/process_memory_dump_unittest.cc
@@ -0,0 +1,55 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/trace_event/process_memory_dump.h"
+
+#include "base/memory/scoped_ptr.h"
+#include "base/trace_event/trace_event_argument.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace base {
+namespace trace_event {
+
+TEST(ProcessMemoryDumpTest, TakeAllDumpsFrom) {
+ scoped_refptr<TracedValue> traced_value(new TracedValue());
+
+ scoped_ptr<ProcessMemoryDump> pmd1(new ProcessMemoryDump(nullptr));
+ pmd1->CreateAllocatorDump("pmd1/mad1");
+ pmd1->CreateAllocatorDump("pmd1/mad2");
+
+ scoped_ptr<ProcessMemoryDump> pmd2(new ProcessMemoryDump(nullptr));
+ pmd2->CreateAllocatorDump("pmd2/mad1");
+ pmd2->CreateAllocatorDump("pmd2/mad2");
+
+ pmd1->TakeAllDumpsFrom(pmd2.get());
+
+ // Make sure that pmd2 is empty but still usable after it has been emptied.
+ ASSERT_TRUE(pmd2->allocator_dumps().empty());
+ pmd2->CreateAllocatorDump("pmd2/this_mad_stays_with_pmd2");
+ ASSERT_EQ(1u, pmd2->allocator_dumps().size());
+ ASSERT_EQ(1u, pmd2->allocator_dumps().count("pmd2/this_mad_stays_with_pmd2"));
+
+ // Check that the AsValueInto doesn't cause a crash.
+ pmd2->AsValueInto(traced_value.get());
+
+ // Free the |pmd2| to check that the memory ownership of the two MAD(s)
+ // has been transferred to |pmd1|.
+ pmd2.reset();
+
+ // Now check that |pmd1| has been effectively merged.
+ ASSERT_EQ(4u, pmd1->allocator_dumps().size());
+ ASSERT_EQ(1u, pmd1->allocator_dumps().count("pmd1/mad1"));
+ ASSERT_EQ(1u, pmd1->allocator_dumps().count("pmd1/mad2"));
+ ASSERT_EQ(1u, pmd1->allocator_dumps().count("pmd2/mad1"));
+ ASSERT_EQ(1u, pmd1->allocator_dumps().count("pmd1/mad2"));
+
+ // Check that the AsValueInto doesn't cause a crash.
+ traced_value = new TracedValue();
+ pmd1->AsValueInto(traced_value.get());
+
+ pmd1.reset();
+}
+
+} // namespace trace_event
+} // namespace base
« no previous file with comments | « base/trace_event/process_memory_dump.cc ('k') | base/trace_event/trace_event.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698