[Android] Add process_resources.py to build Android library resources.

[Android] Add process_resources.py to build Android library resources.

This generates the copy of R.java used to compile the library jar (formerly
done in gyp) and adds a new step to crunch image resources.

The imaging crunching step fixes the link preview 9-patch drawing artifact,
among other benefits.

BUG=163602
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172655

[newt (away), 2012-12-11 02:12:19]

This approach uses a python script to generate R.java and crunch resources.  I
wrote this with the expectation that it might be expanded to take over the tasks
that ant currently performs.

Let me know what you think of the direction.  I haven't polish things completely
(e.g. comments and imports need some fixing) so I'm more interested in general
feedback.

Thanks!

[cjhopman, 2012-12-11 16:54:28]

https://codereview.chromium.org/11516024/diff/1/build/android/process_resourc...
File build/android/process_resources.py (right):

https://codereview.chromium.org/11516024/diff/1/build/android/process_resourc...
build/android/process_resources.py:21: parser.add_option('-D', action='append',
dest='defines',
I'd prefer that each of the required variables were its own regular python
option. I think it will make both the python and gyp files cleaner.

[Yaron, 2012-12-11 18:28:30]

Direction looks good

[newt (away), 2012-12-11 22:03:45]

Ready for real review.

[frankf, 2012-12-11 22:27:01]

Style nit. Please run gpylint as well.

https://codereview.chromium.org/11516024/diff/4002/build/android/process_reso...
File build/android/process_resources.py (right):

https://codereview.chromium.org/11516024/diff/4002/build/android/process_reso...
build/android/process_resources.py:19: parser.add_option('--android_sdk',
help='path to the Android SDK folder')
Using both underscore and dash for options names across scripts really throws me
off. Let's have dashes only which get automatically converted.

[newt (away), 2012-12-11 23:55:32]

https://codereview.chromium.org/11516024/diff/4002/build/android/process_reso...
File build/android/process_resources.py (right):

https://codereview.chromium.org/11516024/diff/4002/build/android/process_reso...
build/android/process_resources.py:19: parser.add_option('--android_sdk',
help='path to the Android SDK folder')
On 2012/12/11 22:27:02, frankf wrote:
> Using both underscore and dash for options names across scripts really throws
me
> off. Let's have dashes only which get automatically converted.

Done.

[Yaron, 2012-12-12 01:07:16]

https://codereview.chromium.org/11516024/diff/9002/build/java.gypi
File build/java.gypi (right):

https://codereview.chromium.org/11516024/diff/9002/build/java.gypi#newcode88
build/java.gypi:88: 'additional_res_dirs': ['<(crunched_res_dir)',
'<(java_in_dir)/res'],
Shouldn't the second list element be the "res_dir" variable in case it's
overridden?

[newt (away), 2012-12-12 01:52:33]

https://codereview.chromium.org/11516024/diff/9002/build/java.gypi
File build/java.gypi (right):

https://codereview.chromium.org/11516024/diff/9002/build/java.gypi#newcode88
build/java.gypi:88: 'additional_res_dirs': ['<(crunched_res_dir)',
'<(java_in_dir)/res'],
On 2012/12/12 01:07:16, Yaron wrote:
> Shouldn't the second list element be the "res_dir" variable in case it's
> overridden?

Yes.

[Yaron, 2012-12-12 01:59:24]

lgtm 

Please wait for other approvals

[frankf, 2012-12-12 02:06:20]

lgtm on the style

[cjhopman, 2012-12-12 18:32:49]

lgtm

[commit-bot: I haz the power, 2012-12-12 18:35:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/newt@chromium.org/11516024/15001

[commit-bot: I haz the power, 2012-12-12 19:42:36]

Retried try job too often on linux_chromeos for step(s) browser_tests,
interactive_ui_tests