Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: gpu/command_buffer/service/buffer_manager.cc

Issue 11516014: Track managed memory usage in the command buffer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix unit test compile error Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/buffer_manager.h ('k') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/buffer_manager.cc
diff --git a/gpu/command_buffer/service/buffer_manager.cc b/gpu/command_buffer/service/buffer_manager.cc
index 3dc5191a4e316aa47eb1f56c1af82c58c0e366d8..001e60204a7003de3876f3bb376699f0b5d5117e 100644
--- a/gpu/command_buffer/service/buffer_manager.cc
+++ b/gpu/command_buffer/service/buffer_manager.cc
@@ -14,12 +14,12 @@ namespace gpu {
namespace gles2 {
BufferManager::BufferManager(MemoryTracker* memory_tracker)
- : buffer_memory_tracker_(new MemoryTypeTracker(memory_tracker)),
+ : memory_tracker_(
+ new MemoryTypeTracker(memory_tracker, MemoryTracker::kManaged)),
allow_buffers_on_multiple_targets_(false),
- mem_represented_(0),
buffer_info_count_(0),
have_context_(true) {
- UpdateMemRepresented();
+ memory_tracker_->UpdateMemRepresented();
}
BufferManager::~BufferManager() {
@@ -30,12 +30,8 @@ BufferManager::~BufferManager() {
void BufferManager::Destroy(bool have_context) {
have_context_ = have_context;
buffer_infos_.clear();
- DCHECK_EQ(0u, mem_represented_);
- UpdateMemRepresented();
-}
-
-void BufferManager::UpdateMemRepresented() {
- buffer_memory_tracker_->UpdateMemRepresented(mem_represented_);
+ DCHECK_EQ(0u, memory_tracker_->GetMemRepresented());
+ memory_tracker_->UpdateMemRepresented();
}
void BufferManager::CreateBufferInfo(GLuint client_id, GLuint service_id) {
@@ -65,9 +61,9 @@ void BufferManager::StartTracking(BufferManager::BufferInfo* /* buffer */) {
}
void BufferManager::StopTracking(BufferManager::BufferInfo* buffer) {
- mem_represented_ -= buffer->size();
+ memory_tracker_->TrackMemFree(buffer->size());
--buffer_info_count_;
- UpdateMemRepresented();
+ memory_tracker_->UpdateMemRepresented();
}
BufferManager::BufferInfo::BufferInfo(BufferManager* manager, GLuint service_id)
@@ -227,12 +223,13 @@ bool BufferManager::GetClientId(GLuint service_id, GLuint* client_id) const {
void BufferManager::SetInfo(
BufferManager::BufferInfo* info, GLsizeiptr size, GLenum usage) {
DCHECK(info);
- mem_represented_ -= info->size();
+ memory_tracker_->TrackMemFree(info->size());
info->SetInfo(size,
usage,
info->target() == GL_ELEMENT_ARRAY_BUFFER ||
allow_buffers_on_multiple_targets_);
- mem_represented_ += info->size();
+ memory_tracker_->TrackMemAlloc(info->size());
+ memory_tracker_->UpdateMemRepresented();
}
bool BufferManager::SetTarget(BufferManager::BufferInfo* info, GLenum target) {
« no previous file with comments | « gpu/command_buffer/service/buffer_manager.h ('k') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698