Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 1151593005: Mark host for style recalc (and child recalc) whenever adding a ShadowRoot (Closed)

Created:
4 years, 11 months ago by esprehn
Modified:
4 years, 11 months ago
Reviewers:
Timothy Loh, hayato
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Mark host for style recalc (and child recalc) whenever adding a ShadowRoot We would forget to mark childNeedsStyleRecalc on the host when adding a ShadowRoot and then if the host was display none never clear the bits on the ShadowRoot which could result in wrong answers from getComputedStyle. Now we mark the bit and also mark the host immediately to ensure the dirty bits are in a consistent state. BUG=492730 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196292

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
A LayoutTests/fast/dom/shadow/shadow-added-display-none-host.html View 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/shadow-added-display-none-host-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
M Source/core/dom/shadow/ElementShadow.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
esprehn
4 years, 11 months ago (2015-06-02 04:47:36 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151593005/20001
4 years, 11 months ago (2015-06-02 04:50:57 UTC) #4
hayato
lgtm
4 years, 11 months ago (2015-06-02 04:56:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151593005/20001
4 years, 11 months ago (2015-06-02 04:58:58 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2015-06-02 07:26:21 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196292

Powered by Google App Engine
This is Rietveld 408576698