Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: Source/core/css/parser/CSSParserValues.cpp

Issue 1151593003: Remove hexDigit check in CSSParserValueList (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/parser/CSSParserValues.cpp
diff --git a/Source/core/css/parser/CSSParserValues.cpp b/Source/core/css/parser/CSSParserValues.cpp
index db8e02a3bc30aeca70b74a530a96c50d37247d37..29cc57c6126c8ad4bd72d13ed4b7dee04209adb8 100644
--- a/Source/core/css/parser/CSSParserValues.cpp
+++ b/Source/core/css/parser/CSSParserValues.cpp
@@ -162,15 +162,6 @@ CSSParserValueList::CSSParserValueList(CSSParserTokenRange range, bool& usesRemU
value.isInt = (token.numericValueType() == IntegerValueType);
break;
case HashToken:
- // FIXME: Move this logic to the property parser
- // This check prevents us from allowing #red and similar
- for (size_t i = 0; i < token.value().length(); ++i) {
- if (!isASCIIHexDigit(token.value()[i])) {
- destroyAndClear();
- return;
- }
- }
- // fallthrough
case StringToken:
case UnicodeRangeToken:
case UrlToken: {
« no previous file with comments | « no previous file | Source/core/css/parser/CSSPropertyParser.cpp » ('j') | Source/core/css/parser/CSSPropertyParser.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698