Generate display product id with EDID manufacturer product code

Generate display product id with EDID manufacturer product code

Formerly the product id for the DisplaySnapshot was generated with a
combination of the manufacturer code combined with a hash of the product
display name. However as the product display name can vary based on
display connector it is more appropriate to use the product code.

TEST=display_unittests passes.
BUG=471749
Committed: https://crrev.com/42e801f538425823057c18221f2be02f4c591fa9
Cr-Commit-Position: refs/heads/master@{#330929}

[robert.bradford, 2015-05-20 15:18:35]

robert.bradford@intel.com changed reviewers:
+ dnicoara@chromium.org, marcheu@chromium.org, oshima@chromium.org

[robert.bradford, 2015-05-20 15:18:35]

dnicoara@ please take a look at the changes in ui/ozone
oshima@ please take a look at the changse in ui/display

marcheu@ does this address your concerns?

[oshima, 2015-05-20 15:37:34]

lgtm

https://codereview.chromium.org/1151583002/diff/1/ui/display/util/edid_parser.cc
File ui/display/util/edid_parser.cc (right):

https://codereview.chromium.org/1151583002/diff/1/ui/display/util/edid_parser...
ui/display/util/edid_parser.cc:56: 0 : base::Hash(product_name);
would you mind moving this code inside following if block?

[robert.bradford, 2015-05-20 17:13:58]

https://codereview.chromium.org/1151583002/diff/1/ui/display/util/edid_parser.cc
File ui/display/util/edid_parser.cc (right):

https://codereview.chromium.org/1151583002/diff/1/ui/display/util/edid_parser...
ui/display/util/edid_parser.cc:56: 0 : base::Hash(product_name);
On 2015/05/20 15:37:33, oshima wrote:
> would you mind moving this code inside following if block?

Done.

[robert.bradford, 2015-05-20 17:30:42]

The CQ bit was checked by robert.bradford@intel.com to run a CQ dry run

[robert.bradford, 2015-05-20 17:30:43]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/1151583002/#ps20001
(title: "Move code as requested by oshima@")

[commit-bot: I haz the power, 2015-05-20 17:31:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1151583002/20001

[dnicoara, 2015-05-20 17:55:32]

lgtm

[commit-bot: I haz the power, 2015-05-20 18:11:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-20 18:11:32]

Dry run: This issue passed the CQ dry run.

[robert.bradford, 2015-05-21 10:51:07]

The CQ bit was checked by robert.bradford@intel.com

[commit-bot: I haz the power, 2015-05-21 10:51:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1151583002/20001

[commit-bot: I haz the power, 2015-05-21 10:54:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-21 10:55:56]

Patchset 2 (id:??) landed as
https://crrev.com/42e801f538425823057c18221f2be02f4c591fa9
Cr-Commit-Position: refs/heads/master@{#330929}