Issue 1151573020: Fix the crash when the drawer is hidden.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1151573020: Fix the crash when the drawer is hidden. (Closed)

Created:
5 years, 6 months ago by Hixie

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix the crash when the drawer is hidden. The root cause of the crash was threefold: - you can't enumerate enums, in dart; you have to enumerate their values. - RenderNodeWrapper was trying to call remove(child.root) on its root, but that's not something that all RenderNodes have - when a RenderNode was deparented, its relayoutSubtreeRoot wasn't removed, so the node ended up in an inconsistent state regarding its parent tree R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9cc97faa7e880c74ab4449c1acc9333ccd211b33

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -15 lines)			Patch
M	sky/sdk/lib/framework/components2/scaffold.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/sdk/lib/framework/fn2.dart	View	3 chunks	+17 lines, -11 lines	0 comments	Download
M	sky/sdk/lib/framework/rendering/node.dart	View	4 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Hixie

5 years, 6 months ago (2015-06-04 17:39:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9cc97faa7e880c74ab4449c1acc9333ccd211b33 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages