Web Animations: Always use svg prefix when animating SVG attributes

Source/core/animation/EffectInput.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 26 matching lines @@
 #include "core/SVGNames.h"
 #include "core/XLinkNames.h"
 #include "core/animation/AnimationInputHelpers.h"
 #include "core/animation/KeyframeEffectModel.h"
 #include "core/animation/StringKeyframe.h"
 #include "core/css/resolver/StyleResolver.h"
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
 #include "core/dom/NodeComputedStyle.h"
 #include "core/svg/animation/SVGSMILElement.h"
+#include "wtf/ASCIICType.h"
 #include "wtf/HashSet.h"
 #include "wtf/NonCopyingSort.h"
 
 namespace blink {
 
 namespace {
 
+bool svgPrefixed(const String& property)
+{
+    return property.length() >= 4 && property.startsWith("svg") && isASCIIUpper(property[3]);
+}
+
 QualifiedName svgAttributeName(String property)
 {
-    if (property.length() >= 4 && property.startsWith("svg")) {
-        // Replace 'svgTransform' with 'transform', etc.
-        property.remove(0, 3);
-        property = property.lower();
-    }
+    // Replace 'svgTransform' with 'transform', etc.
+    ASSERT(svgPrefixed(property));
+    UChar first = toASCIILower(property[3]);
+    property.remove(0, 4);
+    property.insert(&first, 1, 0);

[shans, 2015/06/07 06:42:06]

This differs from the previous behaviour, but I assume this is more correct
(single char toLower rather than whole string)?

[Eric Willigers, 2015/06/09 04:02:12]

Yes, I was sloppy before, it is now correct.

[alancutter (OOO until 2018), 2015/06/09 06:25:05]

So we no longer support animating things like svgcx or svgCX? You should mention
this in the description if it is the case.

 
     if (property == "href")
         return XLinkNames::hrefAttr;
 
     return QualifiedName(nullAtom, AtomicString(property), SVGNames::amplitudeAttr.namespaceURI());
 }
 
 const QualifiedName* supportedSVGAttribute(const String& property, SVGElement* svgElement)
 {
     typedef HashMap<QualifiedName, const QualifiedName*> AttributeNameMap;
@@ skipping 182 matching lines @@
                 keyframe->setPropertyValue(id, value, element, styleSheetContents);
                 continue;
             }
 
             if (property == "offset"
                 || property == "composite"
                 || property == "easing") {
                 continue;
             }
 
-            if (!RuntimeEnabledFeatures::webAnimationsSVGEnabled() || !element->isSVGElement())
+            if (!RuntimeEnabledFeatures::webAnimationsSVGEnabled() || !element->isSVGElement() || !svgPrefixed(property))
                 continue;
 
             SVGElement* svgElement = toSVGElement(element);
             const QualifiedName* qualifiedName = supportedSVGAttribute(property, svgElement);
 
             if (qualifiedName)
                 keyframe->setPropertyValue(*qualifiedName, value, svgElement);
         }
     }
 
@@ skipping 14 matching lines @@
 PassRefPtrWillBeRawPtr<EffectModel> EffectInput::convert(Element* element, const EffectModelOrDictionarySequence& effectInput, ExceptionState& exceptionState)
 {
     if (effectInput.isEffectModel())
         return effectInput.getAsEffectModel();
     if (effectInput.isDictionarySequence())
         return convert(element, effectInput.getAsDictionarySequence(), exceptionState);
     return nullptr;
 }
 
 } // namespace blink