Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1151573010: Pull Sky debugger up to services/debugger. (Closed)

Created:
5 years, 6 months ago by ppi
Modified:
5 years, 6 months ago
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Pull Sky debugger up to services/debugger. Sky debugger is a native mojo app that puts up an http server and talks to other mojo apps in response to http requests, allowing to interactively start/stop tracing, profile, etc. This is generally useful also when one does not run mojo_shell through skydb, hence this patch pulls the debugger into services/debugger. We can then add plumbing for running with the debugger in devtools. Bug: domokit/devtools/#4. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/84b510d3d0d975a34d4b7ada19db7754d44b06a9

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -365 lines) Patch
M services/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
A + services/debugger/BUILD.gn View 1 chunk +2 lines, -10 lines 0 comments Download
A + services/debugger/debugger.cc View 3 chunks +12 lines, -9 lines 0 comments Download
A + services/debugger/trace_collector.h View 2 chunks +3 lines, -5 lines 0 comments Download
A + services/debugger/trace_collector.cc View 2 chunks +1 line, -3 lines 0 comments Download
M sky/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/tools/debugger/BUILD.gn View 1 chunk +0 lines, -38 lines 0 comments Download
D sky/tools/debugger/debugger.cc View 1 chunk +0 lines, -211 lines 0 comments Download
D sky/tools/debugger/trace_collector.h View 1 chunk +0 lines, -40 lines 0 comments Download
D sky/tools/debugger/trace_collector.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M sky/tools/skydb View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ppi
Hi Eric, ptal.
5 years, 6 months ago (2015-06-01 16:06:33 UTC) #2
abarth-chromium
lgtm
5 years, 6 months ago (2015-06-01 16:40:53 UTC) #4
ppi
5 years, 6 months ago (2015-06-01 17:05:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
84b510d3d0d975a34d4b7ada19db7754d44b06a9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698