Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issue 1151563005: Revert of NTP Zombie Code Slayer Part IV: Most Visited (Closed)

Created:
5 years, 7 months ago by Dan Beam
Modified:
5 years, 7 months ago
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, extensions-reviews_chromium.org, donnd+watch_chromium.org, melevin+watch_chromium.org, kmadhusu+watch_chromium.org, dhollowa+watch_chromium.org, vitalyp+closure_chromium.org, jlklein+watch-closure_chromium.org, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-closure_chromium.org, skanuj+watch_chromium.org, dougw+watch_chromium.org, Jered, pedrosimonetti+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of NTP Zombie Code Slayer Part IV: Most Visited (patchset #6 id:100001 of https://codereview.chromium.org/1129903008/) Reason for revert: Duplicate pref registration on Android somehow. Original issue's description: > NTP Zombie Code Slayer Part IV: Most Visited > > This is where things get complicated. > > NTP4 had a most visited pane. It showed your top sites. > So does the current NTP; so I'm trying to remove everything > that deals with most visited tiles on NTP4 without accidentally > breaking the same named thing on the current NTP. > > Here's what used to exist that I'm trying to remove: > http://bostandjiev.com/Content/Google/chrome.jpg > > Here's what currently exists that I'm trying not to break: > http://cdn.ghacks.net/wp-content/uploads/2013/04/chrome-new-tab-page.jpg > > BUG=329637 > > Committed: https://crrev.com/1fc345cd960f7efd4e6b07d1f050615239d82d60 > Cr-Commit-Position: refs/heads/master@{#330845} TBR=samarth@chromium.org,rdevlin.cronin@chromium.org,sky@chromium.org,xiyuan@chromium.org,gab@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=329637 Committed: https://crrev.com/b0909984cb70d10aebe20754703df38efa237525 Cr-Commit-Position: refs/heads/master@{#330876}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1430 lines, -157 lines) Patch
M chrome/browser/extensions/extension_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/top_sites_factory.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/history/top_sites_factory.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/resources/ntp4/apps_page.js View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/resources/ntp4/compiled_resources.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/resources/ntp4/most_visited_page.css View 1 chunk +186 lines, -0 lines 0 comments Download
A chrome/browser/resources/ntp4/most_visited_page.js View 1 chunk +495 lines, -0 lines 0 comments Download
M chrome/browser/resources/ntp4/new_tab.html View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/ntp4/new_tab.js View 7 chunks +48 lines, -1 line 0 comments Download
M chrome/browser/resources/ntp4/new_tab_theme.css View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/resources/ntp4/page_list_view.js View 6 chunks +44 lines, -10 lines 0 comments Download
M chrome/browser/search/instant_service.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/search/thumbnail_source.h View 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/browser/search/thumbnail_source.cc View 1 chunk +0 lines, -66 lines 0 comments Download
M chrome/browser/ui/webui/app_launcher_page_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/ui/webui/ntp/most_visited_browsertest.cc View 1 chunk +29 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/ntp/most_visited_handler.h View 1 chunk +120 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/ntp/most_visited_handler.cc View 1 chunk +294 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_page_handler.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_page_handler.cc View 3 chunks +24 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 2 chunks +12 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/ntp/thumbnail_source.h View 1 chunk +65 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/ntp/thumbnail_source.cc View 1 chunk +66 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/base/web_ui_browser_test.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Dan Beam
Created Revert of NTP Zombie Code Slayer Part IV: Most Visited
5 years, 7 months ago (2015-05-21 02:34:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151563005/1
5 years, 7 months ago (2015-05-21 02:35:39 UTC) #2
Yaron
On 2015/05/21 at 02:35:39, commit-bot wrote: > CQ is trying da patch. Follow status at ...
5 years, 7 months ago (2015-05-21 02:36:04 UTC) #3
newt (away)
lgtm
5 years, 7 months ago (2015-05-21 02:36:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-21 02:37:36 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 02:38:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0909984cb70d10aebe20754703df38efa237525
Cr-Commit-Position: refs/heads/master@{#330876}

Powered by Google App Engine
This is Rietveld 408576698