pkg/analyzer/lib/src/context/context.dart - Issue 1151563004: Optimize AnalysisContext.getSourcesWithFullName().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/context/context.dart

Issue 1151563004: Optimize AnalysisContext.getSourcesWithFullName(). (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/context/context.dart

diff --git a/pkg/analyzer/lib/src/context/context.dart b/pkg/analyzer/lib/src/context/context.dart

index ebf393dc72197d54ca7841a59f6de9efca32ef6f..45f6abbb286a1afc03cca61c85b9a979373193eb 100644

--- a/pkg/analyzer/lib/src/context/context.dart

+++ b/pkg/analyzer/lib/src/context/context.dart

@@ -935,13 +935,7 @@ class AnalysisContextImpl implements InternalAnalysisContext {

@override

List<Source> getSourcesWithFullName(String path) {

- List<Source> sources = <Source>[];

- for (Source source in _cache.sources) {

- if (source.fullName == path) {

- sources.add(source);

- }

- return sources;

+ return analysisCache.getSourcesWithFullName(path);

}

@override