Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1151523014: Fix another -Wsign-compare issue for GCC 4.9.2 (Closed)

Created:
5 years, 6 months ago by paul.l...
Modified:
5 years, 6 months ago
Reviewers:
djordje.pesic, Sven Panne, Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix another -Wsign-compare issue for GCC 4.9.2 BUG= Committed: https://crrev.com/b9588a1d7b5ca0ac19159c2995ec349fc5bc5063 Cr-Commit-Position: refs/heads/master@{#28853}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/deoptimizer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151523014/1
5 years, 6 months ago (2015-06-08 16:14:09 UTC) #2
paul.l...
PTAL.
5 years, 6 months ago (2015-06-08 16:18:37 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-08 18:15:55 UTC) #6
Sven Panne
lgtm
5 years, 6 months ago (2015-06-09 06:10:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151523014/1
5 years, 6 months ago (2015-06-09 06:10:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-09 06:12:55 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 06:13:08 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9588a1d7b5ca0ac19159c2995ec349fc5bc5063
Cr-Commit-Position: refs/heads/master@{#28853}

Powered by Google App Engine
This is Rietveld 408576698