Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Unified Diff: chrome/browser/extensions/api/automation_internal/automation_internal_api.cc

Issue 1151523009: Forward accessibility events to the automation extension process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@step1
Patch Set: Handle case where RenderThread destroys AutomationMessageFilter first Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
diff --git a/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc b/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
index 6b6ec5ed7cae2a90ab7fa0a767fdd98be131073f..7b9e172edd4a407c53694185a785ae1008708929 100644
--- a/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
+++ b/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
@@ -11,6 +11,7 @@
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/accessibility/ax_tree_id_registry.h"
#include "chrome/browser/extensions/api/automation_internal/automation_action_adapter.h"
+#include "chrome/browser/extensions/api/automation_internal/automation_event_router.h"
#include "chrome/browser/extensions/api/automation_internal/automation_util.h"
#include "chrome/browser/extensions/api/tabs/tabs_constants.h"
#include "chrome/browser/extensions/extension_tab_util.h"
@@ -18,6 +19,7 @@
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/common/extensions/api/automation_internal.h"
+#include "chrome/common/extensions/chrome_extension_messages.h"
#include "chrome/common/extensions/manifest_handlers/automation.h"
#include "content/public/browser/ax_event_notification_details.h"
#include "content/public/browser/browser_accessibility_state.h"
@@ -222,8 +224,8 @@ AutomationInternalEnableTabFunction::Run() {
scoped_ptr<Params> params(Params::Create(*args_));
EXTENSION_FUNCTION_VALIDATE(params.get());
content::WebContents* contents = NULL;
- if (params->tab_id.get()) {
- int tab_id = *params->tab_id;
+ if (params->args.tab_id.get()) {
+ int tab_id = *params->args.tab_id;
if (!ExtensionTabUtil::GetTabById(tab_id,
GetProfile(),
include_incognito(),
@@ -247,10 +249,18 @@ AutomationInternalEnableTabFunction::Run() {
return RespondNow(
Error(kCannotRequestAutomationOnPage, contents->GetURL().spec()));
}
+
AutomationWebContentsObserver::CreateForWebContents(contents);
contents->EnableTreeOnlyAccessibilityMode();
int ax_tree_id = AXTreeIDRegistry::GetInstance()->GetOrCreateAXTreeID(
rfh->GetProcess()->GetID(), rfh->GetRoutingID());
+
+ // This gets removed when the extension process dies.
+ AutomationEventRouter::GetInstance()->RegisterListenerForOneTree(
+ source_process_id(),
+ params->args.routing_id,
+ ax_tree_id);
+
return RespondNow(ArgumentList(
api::automation_internal::EnableTab::Results::Create(ax_tree_id)));
}
@@ -351,6 +361,15 @@ AutomationInternalEnableDesktopFunction::Run() {
if (!automation_info || !automation_info->desktop)
return RespondNow(Error("desktop permission must be requested"));
+ using api::automation_internal::EnableDesktop::Params;
+ scoped_ptr<Params> params(Params::Create(*args_));
+ EXTENSION_FUNCTION_VALIDATE(params.get());
+
+ // This gets removed when the extension process dies.
+ AutomationEventRouter::GetInstance()->RegisterListenerWithDesktopPermission(
+ source_process_id(),
+ params->routing_id);
+
AutomationManagerAura::GetInstance()->Enable(browser_context());
return RespondNow(NoArguments());
#else
« no previous file with comments | « chrome/browser/extensions/api/automation_internal/automation_event_router.cc ('k') | chrome/chrome_browser_extensions.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698